Sign upLogin

AsgardCms/User

View on GitHub
Star

Showing 12 of 12 total issues

Method run has 77 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function run()
    {
        Model::unguard();

        $groups = Sentinel::getRoleRepository();
Severity: Major
Found in Database/Seeders/SentinelGroupSeedTableSeeder.php - About 3 hrs to fix

    Method run has 62 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run()
    {
        $this->role->create(array(
            'name'        => 'Admin',
            'permissions' => [
    Severity: Major
    Found in Database/Seeders/UsherTableSeeder.php - About 2 hrs to fix

      Method run has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function run()
    {
        Model::unguard();

        // Create an Admin group
      Severity: Major
      Found in Database/Seeders/SentryGroupSeedTableSeeder.php - About 2 hrs to fix

        Function updateAndSyncRoles has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            public function updateAndSyncRoles($userId, $data, $roles)
    {
        $user = Sentry::findUserById($userId);

        $this->checkForNewPassword($data);
        Severity: Minor
        Found in Repositories/Sentry/SentryUserRepository.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method extendWith has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function extendWith(Menu $menu)
    {
        $menu->group(trans('workshop::workshop.title'), function (Group $group) {

            $group->item(trans('user::users.title.users'), function (Item $item) {
        Severity: Minor
        Found in Sidebar/SidebarExtender.php - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function __call($method, $parameters)
    {
        $class_name = class_basename($this);

        #i: Convert array to dot notation
          Severity: Major
          Found in Entities/Sentry/User.php and 1 other location - About 1 hr to fix
          Entities/Sentinel/User.php on lines 69..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              public function __call($method, $parameters)
    {
        $class_name = class_basename($this);

        #i: Convert array to dot notation
          Severity: Major
          Found in Entities/Sentinel/User.php and 1 other location - About 1 hr to fix
          Entities/Sentry/User.php on lines 65..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 101.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function login has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public function login(array $credentials, $remember = false)
    {
        try {
            Sentry::authenticate($credentials, $remember);
          Severity: Minor
          Found in Repositories/Sentry/SentryAuthentication.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                      return 'User is not activated.';
          Severity: Major
          Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return 'User was not found.';
            Severity: Major
            Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return 'User is suspended.';
              Severity: Major
              Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return 'User is banned.';
                Severity: Major
                Found in Repositories/Sentry/SentryAuthentication.php - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language