Sign upLogin

Asymmetrik/node-rest-starter

View on GitHub
Star
src/app/common/sockets/base-socket.provider.ts

Summary

Maintainability
A
1 hr
Test Coverage

Function payloadHandler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    payloadHandler(topic: string, message: MessageType) {
        // Gracefully handle empty messages by ignoring and logging
        if (null == message) {
            logger.warn(
                `${this.constructor.name}: Ignoring empty message ${message}`
Severity: Minor
Found in src/app/common/sockets/base-socket.provider.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function ignorePayload has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    ignorePayload(message: MessageType, messagePayload: Record<string, unknown>) {
        // Ignore any payloads that are too old.
        if (null != ignoreOlderThan) {
            const messageTime = this.getMessageTime(messagePayload);
            if (null != messageTime) {
Severity: Minor
Found in src/app/common/sockets/base-socket.provider.ts - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status