Sign upLogin

Asymmetrik/node-rest-starter

View on GitHub
Star
src/app/core/teams/teams.controller.spec.ts

Summary

Maintainability
F
1 wk
Test Coverage

File teams.controller.spec.ts has 312 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { Request } from 'express';
import should from 'should';
import { assert, createSandbox, match, stub } from 'sinon';

import { Team, TeamDocument } from './team.model';
Severity: Minor
Found in src/app/core/teams/teams.controller.spec.ts - About 3 hrs to fix

    Function requiresRoleHelper has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            const requiresRoleHelper = (method, testFunction) => {
            describe(method, () => {
                it('user not found', async () => {
                    sandbox.stub(teamsService, 'meetsRoleRequirement').resolves();
    Severity: Minor
    Found in src/app/core/teams/teams.controller.spec.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          describe('teamMemberById', () => {
        it('team found', async () => {
            sandbox.stub(userService, 'read').resolves({
                toObject: () => {
                    return {
      Severity: Major
      Found in src/app/core/teams/teams.controller.spec.ts and 1 other location - About 1 day to fix
      src/app/core/teams/teams.controller.spec.ts on lines 286..320

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 312.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          describe('teamById', () => {
        it('team found', async () => {
            sandbox.stub(teamsService, 'read').resolves({
                toObject: () => {
                    return {
      Severity: Major
      Found in src/app/core/teams/teams.controller.spec.ts and 1 other location - About 1 day to fix
      src/app/core/teams/teams.controller.spec.ts on lines 322..360

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 312.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          describe('updateMemberRole', () => {
        it('request handled', async () => {
            const req = {
                team: new Team(),
                user: new User(),
      Severity: Major
      Found in src/app/core/teams/teams.controller.spec.ts and 2 other locations - About 7 hrs to fix
      src/app/core/teams/teams.controller.spec.ts on lines 179..200
      src/app/core/teams/teams.controller.spec.ts on lines 240..261

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          describe('removeMember', () => {
        it('request handled', async () => {
            const req = {
                team: new Team(),
                user: new User(),
      Severity: Major
      Found in src/app/core/teams/teams.controller.spec.ts and 2 other locations - About 7 hrs to fix
      src/app/core/teams/teams.controller.spec.ts on lines 179..200
      src/app/core/teams/teams.controller.spec.ts on lines 263..284

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          describe('addMember', () => {
        it('request handled', async () => {
            const req = {
                team: new Team(),
                user: new User(),
      Severity: Major
      Found in src/app/core/teams/teams.controller.spec.ts and 2 other locations - About 7 hrs to fix
      src/app/core/teams/teams.controller.spec.ts on lines 240..261
      src/app/core/teams/teams.controller.spec.ts on lines 263..284

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 192.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          describe('search', () => {
        it('search returns teams', async () => {
            const req = {
                body: {}
            };
      Severity: Major
      Found in src/app/core/teams/teams.controller.spec.ts and 2 other locations - About 4 hrs to fix
      src/app/core/feedback/feedback.controller.spec.ts on lines 48..60
      src/app/core/user/eua/eua.controller.spec.ts on lines 29..44

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 119.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status