Sign upLogin

Asymptix/Framework

View on GitHub
Star
classes/Email.php

Summary

Maintainability
A
0 mins
Test Coverage

Missing class import via use statement (line '57', column '23').
Open

            throw new \Exception("Invalid email: '" . $user->email . "'");
Severity: Minor
Found in classes/Email.php by phpmd

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid using static access to class '\Asymptix\core\Validator' in method 'sendSignUpNotification'.
Open

        if (!Validator::isEmail($user->email)) {
Severity: Minor
Found in classes/Email.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The variable $_LANG is not named in camelCase.
Open

    public function sendSignUpNotification($user) {
        global $_LANG;

        if (!Validator::isEmail($user->email)) {
            throw new \Exception("Invalid email: '" . $user->email . "'");
Severity: Minor
Found in classes/Email.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_LANG is not named in camelCase.
Open

    public function sendSignUpAdminNotification($user) {
        global $_LANG;

        return $this->sendNotification(
            Config::EMAIL_ADMIN,
Severity: Minor
Found in classes/Email.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_LANG is not named in camelCase.
Open

    public function sendSignUpAdminNotification($user) {
        global $_LANG;

        return $this->sendNotification(
            Config::EMAIL_ADMIN,
Severity: Minor
Found in classes/Email.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_LANG is not named in camelCase.
Open

    public function sendSignUpNotification($user) {
        global $_LANG;

        if (!Validator::isEmail($user->email)) {
            throw new \Exception("Invalid email: '" . $user->email . "'");
Severity: Minor
Found in classes/Email.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status