Sign upLogin

Asymptix/Framework

View on GitHub
Star
framework/core/Errors.php

Summary

Maintainability
A
0 mins
Test Coverage

The method displayError uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            return ('<span class="label label-danger pull-right form-error">' . $errorMessage . '</span>');
        }
Severity: Minor
Found in framework/core/Errors.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

The variable $_ERRORS is not named in camelCase.
Open

    public static function getError($fieldName) {
        global $_ERRORS;

        if (self::isSetErrorFor($fieldName)) {
            return $_ERRORS[$fieldName];
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function getErrors() {
        global $_ERRORS;

        return isset($_ERRORS['_common']) ? $_ERRORS['_common'] : [];
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function isErrorsExist() {
        global $_ERRORS;

        return isset($_ERRORS['_common']) && !empty($_ERRORS['_common']);
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function saveError($errorMessageText) {
        global $_ERRORS;

        if (!isset($_ERRORS['_common'])) {
            $_ERRORS['_common'] = [];
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function isErrorsExist() {
        global $_ERRORS;

        return isset($_ERRORS['_common']) && !empty($_ERRORS['_common']);
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function saveErrorFor($fieldName, $errorMessageText) {
        global $_ERRORS;

        $_ERRORS[$fieldName] = $errorMessageText;
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function displayErrorFor($fieldName) {
        global $_ERRORS;

        if (self::isSetErrorFor($fieldName)) {
            return self::displayError($_ERRORS[$fieldName], $fieldName);
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function displayErrorFor($fieldName) {
        global $_ERRORS;

        if (self::isSetErrorFor($fieldName)) {
            return self::displayError($_ERRORS[$fieldName], $fieldName);
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function saveErrorFor($fieldName, $errorMessageText) {
        global $_ERRORS;

        $_ERRORS[$fieldName] = $errorMessageText;
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function getErrors() {
        global $_ERRORS;

        return isset($_ERRORS['_common']) ? $_ERRORS['_common'] : [];
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function saveError($errorMessageText) {
        global $_ERRORS;

        if (!isset($_ERRORS['_common'])) {
            $_ERRORS['_common'] = [];
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function isSetErrorFor($fieldName) {
        global $_ERRORS;

        return isset($_ERRORS[$fieldName]);
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function saveError($errorMessageText) {
        global $_ERRORS;

        if (!isset($_ERRORS['_common'])) {
            $_ERRORS['_common'] = [];
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function saveError($errorMessageText) {
        global $_ERRORS;

        if (!isset($_ERRORS['_common'])) {
            $_ERRORS['_common'] = [];
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function getError($fieldName) {
        global $_ERRORS;

        if (self::isSetErrorFor($fieldName)) {
            return $_ERRORS[$fieldName];
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function isSetErrorFor($fieldName) {
        global $_ERRORS;

        return isset($_ERRORS[$fieldName]);
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function getErrors() {
        global $_ERRORS;

        return isset($_ERRORS['_common']) ? $_ERRORS['_common'] : [];
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_ERRORS is not named in camelCase.
Open

    public static function isErrorsExist() {
        global $_ERRORS;

        return isset($_ERRORS['_common']) && !empty($_ERRORS['_common']);
    }
Severity: Minor
Found in framework/core/Errors.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

There are no issues that match your filters.

Category
Status