framework/core/Tools.php
Avoid using undefined variables such as '$_FILTER' which will lead to PHP notices. Open
Open
return isset($_FILTER[$filterName]);- Read upRead up
- Exclude checks
UndefinedVariable
Since: 2.8.0
Detects when a variable is used that has not been defined before.
Example
class Foo
{
private function bar()
{
// $message is undefined
echo $message;
}
}Source https://phpmd.org/rules/cleancode.html#undefinedvariable
Avoid unused local variables such as '$_FILTER'. Open
Open
return isset($_FILTER[$filterName]);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The variable $_FILTER is not named in camelCase. Open
Open
public static function isFilterExists($filterName) {
return isset($_FILTER[$filterName]);
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_FILTER is not named in camelCase. Open
Open
public static function getFilterValue($filterName, $defaultValue = null) {
global $_FILTER;
return isset($_FILTER[$filterName]) ? $_FILTER[$filterName] : $defaultValue;
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_FILTER is not named in camelCase. Open
Open
public static function getFilterValue($filterName, $defaultValue = null) {
global $_FILTER;
return isset($_FILTER[$filterName]) ? $_FILTER[$filterName] : $defaultValue;
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_FILTER is not named in camelCase. Open
Open
public static function getFilterValue($filterName, $defaultValue = null) {
global $_FILTER;
return isset($_FILTER[$filterName]) ? $_FILTER[$filterName] : $defaultValue;
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}