Asymptix/Framework

View on GitHub
framework/db/DBCore.php

Summary

Maintainability
D
2 days
Test Coverage

File DBCore.php has 438 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace Asymptix\db;

use Asymptix\core\Tools;
Severity: Minor
Found in framework/db/DBCore.php - About 6 hrs to fix

    DBCore has 36 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class DBCore {
        /**
         * An array containing all the opened connections.
         *
         * @var array
    Severity: Minor
    Found in framework/db/DBCore.php - About 4 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if (strpos($type, "varchar") === 0
               || strpos($type, "text") === 0
               || strpos($type, "longtext") === 0
               || strpos($type, "enum") === 0
               || strpos($type, "char") === 0
      Severity: Critical
      Found in framework/db/DBCore.php - About 3 hrs to fix

        The class DBCore has an overall complexity of 123 which is very high. The configured complexity threshold is 50.
        Open

        class DBCore {
            /**
             * An array containing all the opened connections.
             *
             * @var array
        Severity: Minor
        Found in framework/db/DBCore.php by phpmd

        The class DBCore has 23 public methods. Consider refactoring DBCore to keep number of public methods under 10.
        Open

        class DBCore {
            /**
             * An array containing all the opened connections.
             *
             * @var array
        Severity: Minor
        Found in framework/db/DBCore.php by phpmd

        TooManyPublicMethods

        Since: 0.1

        A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

        By default it ignores methods starting with 'get' or 'set'.

        Example

        Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

        The class DBCore has 26 non-getter- and setter-methods. Consider refactoring DBCore to keep number of methods under 25.
        Open

        class DBCore {
            /**
             * An array containing all the opened connections.
             *
             * @var array
        Severity: Minor
        Found in framework/db/DBCore.php by phpmd

        TooManyMethods

        Since: 0.1

        A class with too many methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

        By default it ignores methods starting with 'get' or 'set'.

        The default was changed from 10 to 25 in PHPMD 2.3.

        Example

        Source https://phpmd.org/rules/codesize.html#toomanymethods

        Method getPrintableSQLValue has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function getPrintableSQLValue($type, $value) {
                if (strpos($type, "varchar") === 0
                 || strpos($type, "text") === 0
                 || strpos($type, "longtext") === 0
                 || strpos($type, "enum") === 0
        Severity: Minor
        Found in framework/db/DBCore.php - About 1 hr to fix

          Function getPrintableSQLValue has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              private static function getPrintableSQLValue($type, $value) {
                  if (strpos($type, "varchar") === 0
                   || strpos($type, "text") === 0
                   || strpos($type, "longtext") === 0
                   || strpos($type, "enum") === 0
          Severity: Minor
          Found in framework/db/DBCore.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function bindResults has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function bindResults($stmt) {
                  $resultSet = [];
                  $metaData = $stmt->result_metadata();
                  $fieldsCounter = 0;
                  while ($field = $metaData->fetch_field()) {
          Severity: Minor
          Found in framework/db/DBCore.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function selectDBObjectsFromStatement has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function selectDBObjectsFromStatement($stmt, $className) {
                  if (is_object($className)) {
                      $className = get_class($className);
                  }
          
          
          Severity: Minor
          Found in framework/db/DBCore.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function selectSingleRecord has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function selectSingleRecord($query, $types = "", $params = []) {
                  if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
                      $dbQuery = new DBPreparedQuery($query, $types, $params);
                  } else {
                      $dbQuery = $query;
          Severity: Minor
          Found in framework/db/DBCore.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function selectDBObjectFromStatement has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function selectDBObjectFromStatement($stmt, $className) {
                  if (is_object($className)) {
                      $className = get_class($className);
                  }
          
          
          Severity: Minor
          Found in framework/db/DBCore.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function selectSingleValue has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function selectSingleValue($query, $types = "", $params = []) {
                  if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
                      $dbQuery = new DBPreparedQuery($query, $types, $params);
                  } else {
                      $dbQuery = $query;
          Severity: Minor
          Found in framework/db/DBCore.php - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                  return $value;
          Severity: Major
          Found in framework/db/DBCore.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return "0.0";
            Severity: Major
            Found in framework/db/DBCore.php - About 30 mins to fix

              Function getTableFieldsList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function getTableFieldsList($tableName) {
                      if (!empty($tableName)) {
                          $query = "SHOW FULL COLUMNS FROM " . $tableName;
                          $stmt = self::doSelectQuery($query);
                          if ($stmt !== false) {
              Severity: Minor
              Found in framework/db/DBCore.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function displayTableFieldsList has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static function displayTableFieldsList($tableName) {
                      print("<pre>");
                      if (!empty($tableName)) {
                          $fieldsList = self::getTableFieldsList($tableName);
                          if (!empty($fieldsList)) {
              Severity: Minor
              Found in framework/db/DBCore.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function doQuery has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private static function doQuery($query, $types = "", $params = []) {
                      if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
                          $dbQuery = new DBPreparedQuery($query, $types, $params);
                      } else {
                          $dbQuery = $query;
              Severity: Minor
              Found in framework/db/DBCore.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              The method getPrintableSQLValue() has a Cyclomatic Complexity of 19. The configured cyclomatic complexity threshold is 10.
              Open

                  private static function getPrintableSQLValue($type, $value) {
                      if (strpos($type, "varchar") === 0
                       || strpos($type, "text") === 0
                       || strpos($type, "longtext") === 0
                       || strpos($type, "enum") === 0
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              CyclomaticComplexity

              Since: 0.1

              Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

              Example

              // Cyclomatic Complexity = 11
              class Foo {
              1   public function example() {
              2       if ($a == $b) {
              3           if ($a1 == $b1) {
                              fiddle();
              4           } elseif ($a2 == $b2) {
                              fiddle();
                          } else {
                              fiddle();
                          }
              5       } elseif ($c == $d) {
              6           while ($c == $d) {
                              fiddle();
                          }
              7        } elseif ($e == $f) {
              8           for ($n = 0; $n < $h; $n++) {
                              fiddle();
                          }
                      } else {
                          switch ($z) {
              9               case 1:
                                  fiddle();
                                  break;
              10              case 2:
                                  fiddle();
                                  break;
              11              case 3:
                                  fiddle();
                                  break;
                              default:
                                  fiddle();
                                  break;
                          }
                      }
                  }
              }

              Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

              Avoid using undefined variables such as '$extra' which will lead to PHP notices.
              Open

                                      'extra' => $extra,
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$null' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$extra' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$type' which will lead to PHP notices.
              Open

                                      'type' => $type,
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$default' which will lead to PHP notices.
              Open

                                      'default' => $default,
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$field' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$parameters' which will lead to PHP notices.
              Open

                                  $fieldValue = $parameters[$fieldValue];
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$parameters' which will lead to PHP notices.
              Open

                      call_user_func_array([$stmt, 'bind_result'], $parameters);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$key' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$null' which will lead to PHP notices.
              Open

                                      'null' => $null,
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$collation' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$field' which will lead to PHP notices.
              Open

                                  $fieldsList[$field] = [
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$key' which will lead to PHP notices.
              Open

                                      'key' => $key,
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$privileges' which will lead to PHP notices.
              Open

                                      'privileges' => $privileges,
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$default' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$privileges' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$comment' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$comment' which will lead to PHP notices.
              Open

                                      'comment' => $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$parameters' which will lead to PHP notices.
              Open

                          $parameters[] = &$$parameterName;
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$type' which will lead to PHP notices.
              Open

                                  $field, $type, $collation, $null, $key, $default, $extra, $privileges, $comment
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              Avoid using undefined variables such as '$collation' which will lead to PHP notices.
              Open

                                      'collation' => $collation,
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              UndefinedVariable

              Since: 2.8.0

              Detects when a variable is used that has not been defined before.

              Example

              class Foo
              {
                  private function bar()
                  {
                      // $message is undefined
                      echo $message;
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#undefinedvariable

              The method insertDBObject has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public static function insertDBObject($dbObject, $ignore = false, $debug = false) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
                  public function bar($flag = true) {
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              The method insertDBObject has a boolean flag argument $ignore, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public static function insertDBObject($dbObject, $ignore = false, $debug = false) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
                  public function bar($flag = true) {
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              The method updateDBObject has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation.
              Open

                  public static function updateDBObject($dbObject, $debug = false) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              BooleanArgumentFlag

              Since: 1.4.0

              A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

              Example

              class Foo {
                  public function bar($flag = true) {
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

              The method doUpdateQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $dbQuery = $query;
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'Asymptix\db\DBPreparedQuery' in method 'insertDBObject'.
              Open

                          $typesString = DBPreparedQuery::sqlTypesString($fieldsList, $idFieldName);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'Asymptix\db\DBQuery' in method 'insertDBObject'.
              Open

                          DBQuery::showQueryDebugInfo($query, $typesString, $valuesList);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'Asymptix\db\DBPreparedQuery' in method 'updateDBObject'.
              Open

                                SET " . DBPreparedQuery::sqlQMValuesString($fieldsList, $idFieldName) . "
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Asymptix\core\Tools' in method 'updateDBObject'.
              Open

                      if (Tools::isInteger($fieldsList[$idFieldName])) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Asymptix\core\Tools' in method 'doQuery'.
              Open

                      if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'Asymptix\db\DBPreparedQuery' in method 'insertDBObject'.
              Open

                                        SET " . DBPreparedQuery::sqlQMValuesString($fieldsList);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method doQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              throw new DBCoreException(
                                  "Number of types is not equal parameters number or types string is invalid"
                              );
                          }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class '\Asymptix\core\Tools' in method 'doUpdateQuery'.
              Open

                      if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'Asymptix\db\DBPreparedQuery' in method 'insertDBObject'.
              Open

                          $typesString = DBPreparedQuery::sqlTypesString($fieldsList);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'Asymptix\db\DBQuery' in method 'updateDBObject'.
              Open

                          DBQuery::showQueryDebugInfo($query, $typesString, $valuesList);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method insertDBObject uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $query = "INSERT " . ($ignore ? 'IGNORE' : 'INTO') . " " . $dbObject->getTableName() . "
                                        SET " . DBPreparedQuery::sqlQMValuesString($fieldsList);
                          $typesString = DBPreparedQuery::sqlTypesString($fieldsList);
                          $valuesList = self::createValuesList($fieldsList);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class 'Asymptix\db\DBPreparedQuery' in method 'updateDBObject'.
              Open

                      $typesString = DBPreparedQuery::sqlTypesString($fieldsList, $idFieldName);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Asymptix\core\Tools' in method 'deleteDBObject'.
              Open

                          if (Tools::isInteger($dbObject->getId())) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Asymptix\core\Tools' in method 'selectSingleRecord'.
              Open

                      if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class '\Asymptix\core\Tools' in method 'selectSingleValue'.
              Open

                      if (!Tools::isInstanceOf($query, new DBPreparedQuery())) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method updateDBObject uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $typesString.= "s";
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method doQuery uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $dbQuery = $query;
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method updateDBObject uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          return self::doUpdateQuery($query, $typesString, $valuesList);
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method selectDBObjectsFromStatement uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                              } else {
                                  $objectsList[] = $dbObject;
                              }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class '\Asymptix\core\Tools' in method 'closeConnection'.
              Open

                      if (Tools::isObject($connection)) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              Avoid using static access to class 'Asymptix\db\DBPreparedQuery' in method 'insertDBObject'.
              Open

                                        SET " . DBPreparedQuery::sqlQMValuesString($fieldsList, $idFieldName);
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method openConnection uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $connName = $this->index;
                          $this->index++;
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method getPrintableFieldString uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $fieldStr.= self::getPrintableSQLValue($attributes['type'], $attributes['default']);
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid using static access to class '\Asymptix\core\Tools' in method 'insertDBObject'.
              Open

                      if (Tools::isInteger($fieldsList[$idFieldName])) {
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              StaticAccess

              Since: 1.4.0

              Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

              Example

              class Foo
              {
                  public function bar()
                  {
                      Bar::baz();
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#staticaccess

              The method selectDBObjectFromStatement uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                              return null;
                          }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method selectSingleRecord uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $dbQuery = $query;
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method selectSingleValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
                          $dbQuery = $query;
                      }
              Severity: Minor
              Found in framework/db/DBCore.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
              {
                  public function bar($flag)
                  {
                      if ($flag) {
                          // one branch
                      } else {
                          // another branch
                      }
                  }
              }

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              There are no issues that match your filters.

              Category
              Status