Sign upLogin

Asymptix/Framework

View on GitHub
Star
framework/db/DBField.php

Summary

Maintainability
B
5 hrs
Test Coverage

Function __construct has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function __construct($type = "", $name = "", $value = null) {
        if (!(bool)preg_match("#^[a-zA-Z][a-zA-Z0-9_]*$#", $name)) {
            throw new DBFieldException("Can't create DBField object: invalid field name '" . $name . "'");
        }
        $this->name = $name;
Severity: Minor
Found in framework/db/DBField.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method __construct has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($type = "", $name = "", $value = null) {
        if (!(bool)preg_match("#^[a-zA-Z][a-zA-Z0-9_]*$#", $name)) {
            throw new DBFieldException("Can't create DBField object: invalid field name '" . $name . "'");
        }
        $this->name = $name;
Severity: Minor
Found in framework/db/DBField.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

                return "s";
    Severity: Major
    Found in framework/db/DBField.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                          return "TRUE";
      Severity: Major
      Found in framework/db/DBField.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return "FALSE";
        Severity: Major
        Found in framework/db/DBField.php - About 30 mins to fix

          Function getType has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public static function getType($fieldValue) {
        if (is_null($fieldValue)) { // Type is not principled for NULL
            return "i";
        } elseif (Tools::isInteger($fieldValue)) {
            return "i";
          Severity: Minor
          Found in framework/db/DBField.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          The method __construct() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
          Open

              public function __construct($type = "", $name = "", $value = null) {
        if (!(bool)preg_match("#^[a-zA-Z][a-zA-Z0-9_]*$#", $name)) {
            throw new DBFieldException("Can't create DBField object: invalid field name '" . $name . "'");
        }
        $this->name = $name;
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          CyclomaticComplexity

          Since: 0.1

          Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

          Example

          // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

          Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

          Avoid using static access to class '\Asymptix\core\Tools' in method 'getType'.
          Open

                  } elseif (Tools::isDouble($fieldValue)) {
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Asymptix\core\Tools' in method 'getType'.
          Open

                  } elseif (Tools::isBoolean($fieldValue)) {
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method getType uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
            throw new DBFieldTypeException(
                "Can't detect field value type for value '" . (string)$fieldValue . "'"
            );
        }
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method sqlValue uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                          } else {
                    return $value;
                }
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                  } else {
            $this->type = self::castType($type);
            if (!is_null($value)) {
                switch ($this->type) {
                    case ("i"):
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          Avoid using static access to class '\Asymptix\core\Tools' in method 'getType'.
          Open

                  } elseif (Tools::isString($fieldValue)) {
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          Avoid using static access to class '\Asymptix\core\Tools' in method 'getType'.
          Open

                  } elseif (Tools::isInteger($fieldValue)) {
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          StaticAccess

          Since: 1.4.0

          Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

          Example

          class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

          Source https://phpmd.org/rules/cleancode.html#staticaccess

          The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
          Open

                      } else {
                $this->type = self::getType($value);
                $this->value = $value;
            }
          Severity: Minor
          Found in framework/db/DBField.php by phpmd

          ElseExpression

          Since: 1.4.0

          An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

          Example

          class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

          Source https://phpmd.org/rules/cleancode.html#elseexpression

          There are no issues that match your filters.

          Category
          Status