Sign upLogin

Asymptix/Framework

View on GitHub
Star
framework/db/DBSelector.php

Summary

Maintainability
B
4 hrs
Test Coverage

The class DBSelector has 11 public methods. Consider refactoring DBSelector to keep number of public methods under 10.
Open

class DBSelector extends \Asymptix\core\BasicObject {
    protected $fieldsList = [
        'conditions' => "",
        'order' => "",
        'offset' => 0,
Severity: Minor
Found in framework/db/DBSelector.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method __call has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __call($methodName, $methodParams) {
        /*
         * Selects DBObject record by some field value.
         *
         * @param <mixed> Value of the field
Severity: Minor
Found in framework/db/DBSelector.php - About 1 hr to fix

    Function __call has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __call($methodName, $methodParams) {
        /*
         * Selects DBObject record by some field value.
         *
         * @param <mixed> Value of the field
    Severity: Minor
    Found in framework/db/DBSelector.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return $this->selectDBObjects();
    Severity: Major
    Found in framework/db/DBSelector.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return $this->getFieldValue($fieldName);
      Severity: Major
      Found in framework/db/DBSelector.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return $this->setFieldValue($fieldName, $fieldValue);
        Severity: Major
        Found in framework/db/DBSelector.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this->selectDBObject();
          Severity: Major
          Found in framework/db/DBSelector.php - About 30 mins to fix

            The method __call() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
            Open

                public function __call($methodName, $methodParams) {
        /*
         * Selects DBObject record by some field value.
         *
         * @param <mixed> Value of the field
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            CyclomaticComplexity

            Since: 0.1

            Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

            Example

            // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

            Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

            The method selectDBObject has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function selectDBObject($debug = false) {
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
    public function bar($flag = true) {
    }
}

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method selectDBObjectByField has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function selectDBObjectByField($fieldName, $fieldValue, $debug = false) {
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
    public function bar($flag = true) {
    }
}

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method selectDBObjectById has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function selectDBObjectById($objectId = null, $debug = false) {
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
    public function bar($flag = true) {
    }
}

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method selectDBObjects has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function selectDBObjects($debug = false) {
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
    public function bar($flag = true) {
    }
}

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            The method selectDBObjectsByField has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation.
            Open

                public function selectDBObjectsByField($fieldName, $fieldValue, $debug = false) {
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            BooleanArgumentFlag

            Since: 1.4.0

            A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

            Example

            class Foo {
    public function bar($flag = true) {
    }
}

            Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

            Avoid using static access to class 'Asymptix\db\DBQueryCondition' in method 'setConditions'.
            Open

                        $conditions = DBQueryCondition::getSQLCondition($conditions);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObjectsByField'.
            Open

                        $stmt = DBCore::doSelectQuery($query, $fieldType, [$fieldValue]);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBQuery' in method 'selectDBObjectsByField'.
            Open

                    DBQuery::showQueryDebugInfo($query, $fieldType, [$fieldValue]);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBQuery' in method 'selectDBObjectByField'.
            Open

                    DBQuery::showQueryDebugInfo($query, $fieldType, [$fieldValue]);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObjects'.
            Open

                        $stmt = DBCore::doSelectQuery($query);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObjectByField'.
            Open

                            $dbObject = DBCore::selectDBObjectFromStatement($stmt, $this->dbObject);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObjectsByField'.
            Open

                            $dbObjects = DBCore::selectDBObjectsFromStatement($stmt, get_class($this->dbObject));
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBQuery' in method 'selectDBObject'.
            Open

                    DBQuery::showQueryDebugInfo($query);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBField' in method 'selectDBObjectByField'.
            Open

                    $fieldType = DBField::getType($fieldValue);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'count'.
            Open

                    return DBCore::selectSingleValue($query);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBQuery' in method 'selectDBObjects'.
            Open

                    DBQuery::showQueryDebugInfo($query);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObject'.
            Open

                            $dbObject = DBCore::selectDBObjectFromStatement($stmt, $this->dbObject);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'max'.
            Open

                    return DBCore::selectSingleValue($query);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObjectByField'.
            Open

                        $stmt = DBCore::doSelectQuery($query, $fieldType, [$fieldValue]);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObjects'.
            Open

                            $dbObjects = DBCore::selectDBObjectsFromStatement($stmt, $this->dbObject);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBField' in method 'selectDBObjectsByField'.
            Open

                    $fieldType = DBField::getType($fieldValue);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'selectDBObject'.
            Open

                        $stmt = DBCore::doSelectQuery($query);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            Avoid using static access to class 'Asymptix\db\DBCore' in method 'min'.
            Open

                    return DBCore::selectSingleValue($query);
            Severity: Minor
            Found in framework/db/DBSelector.php by phpmd

            StaticAccess

            Since: 1.4.0

            Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

            Example

            class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

            Source https://phpmd.org/rules/cleancode.html#staticaccess

            There are no issues that match your filters.

            Category
            Status