The method save has a boolean flag argument $debug, which is a certain sign of a Single Responsibility Principle violation. Open
public function save($debug = false) {- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
Avoid using static access to class 'Asymptix\db\DBCore' in method 'saveActivationFlag'. Open
return DBCore::doUpdateQuery(
"UPDATE " . static::TABLE_NAME . "
SET activation = ?,
update_time = ?,
update_user_id = ?- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->changeUpdateTime();
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using static access to class 'Asymptix\db\DBCore' in method 'saveRemovementFlag'. Open
return DBCore::doUpdateQuery(
"UPDATE " . static::TABLE_NAME . "
SET removed = ?,
update_time = ?,
update_user_id = ?- Read upRead up
- Exclude checks
StaticAccess
Since: 1.4.0
Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.
Example
class Foo
{
public function bar()
{
Bar::baz();
}
}Source https://phpmd.org/rules/cleancode.html#staticaccess
The variable $_USER is not named in camelCase. Open
private function changeUpdateTime() {
global $_USER;
$this->updateTime = date("Y-m-d H:i:s");
$this->updateUserId = $_USER->id;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_USER is not named in camelCase. Open
private function changeCreateTime() {
global $_USER;
$this->createTime = date("Y-m-d H:i:s");
$this->createUserId = $_USER->id;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_USER is not named in camelCase. Open
private function changeUpdateTime() {
global $_USER;
$this->updateTime = date("Y-m-d H:i:s");
$this->updateUserId = $_USER->id;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $_USER is not named in camelCase. Open
private function changeCreateTime() {
global $_USER;
$this->createTime = date("Y-m-d H:i:s");
$this->createUserId = $_USER->id;- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}