Sign upLogin

Asymptix/Framework

View on GitHub
Star
framework/mail/Email.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method sendNotification has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

            $email, $subject, $languageCode, $template,
            array $params = null, $format = self::FORMAT_TEXT,
            $replyTo = ""
Severity: Major
Found in framework/mail/Email.php - About 50 mins to fix

    Method send has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public static function send($to, $subject, $message, $headers = [], $parameters = "") {
    Severity: Minor
    Found in framework/mail/Email.php - About 35 mins to fix

      Method sendMail has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          protected function sendMail($email, $subject, $message, $format = self::FORMAT_TEXT, $replyTo = "") {
      Severity: Minor
      Found in framework/mail/Email.php - About 35 mins to fix

        Avoid using static access to class '\Asymptix\core\Validator' in method '__construct'.
        Open

                if (!Validator::isEmail($fromEmail)) {
        Severity: Minor
        Found in framework/mail/Email.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid using static access to class '\Asymptix\core\Content' in method 'send'.
        Open

                    $message = Content::render($tplPath, $tplVars);
        Severity: Minor
        Found in framework/mail/Email.php by phpmd

        StaticAccess

        Since: 1.4.0

        Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

        Example

        class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

        Source https://phpmd.org/rules/cleancode.html#staticaccess

        Avoid unused local variables such as '$_EMAIL'.
        Open

                $_EMAIL = $params;
        Severity: Minor
        Found in framework/mail/Email.php by phpmd

        UnusedLocalVariable

        Since: 0.2

        Detects when a local variable is declared and/or assigned, but not used.

        Example

        class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

        Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

        Avoid variables with short names like $to. Configured minimum length is 3.
        Open

            public static function send($to, $subject, $message, $headers = [], $parameters = "") {
        Severity: Minor
        Found in framework/mail/Email.php by phpmd

        ShortVariable

        Since: 0.2

        Detects when a field, local, or parameter has a very short name.

        Example

        class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

        Source https://phpmd.org/rules/naming.html#shortvariable

        The variable $_EMAIL is not named in camelCase.
        Open

            protected function sendNotification(
            $email, $subject, $languageCode, $template,
            array $params = null, $format = self::FORMAT_TEXT,
            $replyTo = ""
        ) {
        Severity: Minor
        Found in framework/mail/Email.php by phpmd

        CamelCaseVariableName

        Since: 0.2

        It is considered best practice to use the camelCase notation to name variables.

        Example

        class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

        Source

        There are no issues that match your filters.

        Category
        Status