Sign upLogin

Asymptix/Framework

View on GitHub
Star
framework/ui/components/UIListOption.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __construct has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($optionValue, $option, $currentValue, $template = "") {
        if (empty($template)) {
            $template = self::DEFAULT_TEMPLATE;
        }
        if (isObject($option)) {
Severity: Minor
Found in framework/ui/components/UIListOption.php - About 1 hr to fix

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            parent::__construct(
                [
                    'value' => $optionValue,
                    'title' => $option
    Severity: Minor
    Found in framework/ui/components/UIListOption.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    There are no issues that match your filters.

    Category
    Status