Sign upLogin

AthensFramework/core

View on GitHub
Star
src/admin/Admin.php

Summary

Maintainability
C
1 day
Test Coverage

Method makeDetail has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function makeDetail()
    {
        /** @var boolean $idWasProvided */
        $idWasProvided = static::getObjectId() !== null;
Severity: Major
Found in src/admin/Admin.php - About 2 hrs to fix

    Method makeTables has 58 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        protected function makeTables($queries = null)
    {
        /** @var WritableInterface[] $tables */
        $tables = [];
    Severity: Major
    Found in src/admin/Admin.php - About 2 hrs to fix

      File Admin.php has 254 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php

namespace Athens\Core\Admin;

use Athens\Core\Etc\StringUtils;
      Severity: Minor
      Found in src/admin/Admin.php - About 2 hrs to fix

        Method __construct has 42 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function __construct(
        $id,
        $type,
        array $classes,
        array $data,
        Severity: Minor
        Found in src/admin/Admin.php - About 1 hr to fix

          Method __construct has 10 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  $id,
        $type,
        array $classes,
        array $data,
        $title,
          Severity: Major
          Found in src/admin/Admin.php - About 1 hr to fix

            Function __construct has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function __construct(
        $id,
        $type,
        array $classes,
        array $data,
            Severity: Minor
            Found in src/admin/Admin.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            There are no issues that match your filters.

            Category
            Status