Sign upLogin

AugurProject/augur-core

View on GitHub
Star

Showing 833 of 833 total issues

Function contractInterfaceTemplate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    private contractInterfaceTemplate(contractName: String, contractAbi: Abi) {
        const contractMethods: Array<String> = [];

        // Typescript doesn't allow the same name for a function. We only have one existing case for function overloading in a class and it has the same signature, so this is ok at the moment.
        const seen: Set<string> = new Set();
Severity: Minor
Found in source/libraries/ContractInterfacesGenerator.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function deploy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public async deploy(): Promise<void> {
        const blockNumber = await this.getBlockNumber();
        this.controller = await this.uploadController();
        await this.uploadAugur();
        await this.uploadAllContracts();
Severity: Minor
Found in source/libraries/ContractDeployer.ts - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        if (contract.relativeFilePath.startsWith('legacy_reputation/')) return;
Severity: Major
Found in source/libraries/ContractDeployer.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                    return 'Array<string>';
    Severity: Major
    Found in source/libraries/ContractInterfacesGenerator.ts - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return 'Array<BN>';
      Severity: Major
      Found in source/libraries/ContractInterfacesGenerator.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                if (contractName === 'Augur') return;
        Severity: Major
        Found in source/libraries/ContractDeployer.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  if (contractName !== 'Map' && contract.relativeFilePath.startsWith('libraries/')) return;
          Severity: Major
          Found in source/libraries/ContractDeployer.ts - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    if (this.configuration.isProduction && contractName === 'LegacyReputationToken') return;
            Severity: Major
            Found in source/libraries/ContractDeployer.ts - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public async proceedToInitialReporting(fixture: TestFixture, market: Market) {
        const designatedReportingEndTime = await market.getDesignatedReportingEndTime_();
        await fixture.setTimestamp(designatedReportingEndTime.add(new BN(1)));
    }
              Severity: Minor
              Found in source/tests-integration/ReportingUtils.ts and 1 other location - About 30 mins to fix
              source/tests-integration/ReportingUtils.ts on lines 9..12

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  public async proceedToDesignatedReporting(fixture: TestFixture, market: Market) {
        const marketEndTime = await market.getEndTime_();
        await fixture.setTimestamp(marketEndTime.add(new BN(1)));
    }
              Severity: Minor
              Found in source/tests-integration/ReportingUtils.ts and 1 other location - About 30 mins to fix
              source/tests-integration/ReportingUtils.ts on lines 14..17

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function signTransaction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public async signTransaction(transaction: Transaction): Promise<string> {
        const sender = transaction.from || this.defaultAddress;
        if (typeof transaction.data === 'undefined') throw new Error(`transaction.data was undefined.`);
        if (typeof transaction.gas === 'undefined') throw new Error(`transaction.gas was undefined.`);
        if (typeof transaction.gasPrice === 'undefined') throw new Error(`transaction.gasPrice was undefined.`);
              Severity: Minor
              Found in source/libraries/AccountManager.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function main has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              def main():
    parser = argparse.ArgumentParser()

    parser.add_argument("-a", "--analyze", help="Do some sort of programatic analysis. Right now nothing interesting. Later!", action="store_true")
    parser.add_argument("-p", "--prettyprint", help="Pretty print results of the run like the oyente tool typically does", action="store_true")
              Severity: Minor
              Found in source/tools/runOyente.py - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public static create(networkName: string="environment", validatePrivateKey: boolean=true): NetworkConfiguration {
        const network = networks[networkName];

        if (network === undefined || network === null) throw new Error(`Network configuration ${networkName} not found`);
        if (validatePrivateKey && (network.privateKey === undefined || network.privateKey === null)) throw new Error(`Network configuration for ${networkName} has no private key available. Check that this key is in the environment ${networkName == "environment" ? "ETHEREUM" : networkName.toUpperCase()}_PRIVATE_KEY`);
              Severity: Minor
              Found in source/libraries/NetworkConfiguration.ts - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language