Sign upLogin

AugurProject/augur-ui

View on GitHub
Star
integration/helpers/liquidity.ts

Summary

Maintainability
C
1 day
Test Coverage

Function createLiquidity has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export async function createLiquidity(orders: Array<LiquidityOrder>) {
  let askOrders: LiquidityChartRows = {};
  let bidOrders: LiquidityChartRows = {};
  let currentOrdersArray;
  for (let order of orders) {
Severity: Major
Found in integration/helpers/liquidity.ts - About 2 hrs to fix

    Function verifyLiquidityOrderBook has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export async function verifyLiquidityOrderBook(
  askOrders: LiquidityChartRows,
  bidOrders: LiquidityChartRows,
  timeoutMilliseconds = 10000
) {
    Severity: Minor
    Found in integration/helpers/liquidity.ts - About 1 hr to fix

      Function createLiquidity has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      export async function createLiquidity(orders: Array<LiquidityOrder>) {
  let askOrders: LiquidityChartRows = {};
  let bidOrders: LiquidityChartRows = {};
  let currentOrdersArray;
  for (let order of orders) {
      Severity: Minor
      Found in integration/helpers/liquidity.ts - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function verifyLiquidity has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export async function verifyLiquidity(
  orders: Array<LiquidityOrder>,
  timeoutMilliseconds = 10000
) {
  for (let i = 0; i < orders.length; i++) {
      Severity: Minor
      Found in integration/helpers/liquidity.ts - About 1 hr to fix

        TODO found
        Open

                // TODO: Ideally, we should also be calculating depth and verifying it
        Severity: Minor
        Found in integration/helpers/liquidity.ts by fixme

        TODO found
        Open

            // TODO: Add check to verify that depth is correct
        Severity: Minor
        Found in integration/helpers/liquidity.ts by fixme

        TODO found
        Open

            // TODO: Add check to verify that depth is correct
        Severity: Minor
        Found in integration/helpers/liquidity.ts by fixme

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            await expect(page).toMatchElement(
      ".market-positions-list-styles_MarketPositionsList__table-body .market-positions-list--order-styles_Order:nth-child(" +
        row +
        ") li:nth-child(3)",
      { text: orders[i].quantity, timeout: timeoutMilliseconds }
        Severity: Minor
        Found in integration/helpers/liquidity.ts and 2 other locations - About 30 mins to fix
        integration/helpers/liquidity.ts on lines 157..162
        integration/helpers/liquidity.ts on lines 181..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            await expect(page).toMatchElement(
      ".market-positions-list-styles_MarketPositionsList__table-body .market-positions-list--order-styles_Order:nth-child(" +
        row +
        ") li:nth-child(1)",
      { text: orders[i].outcome, timeout: timeoutMilliseconds }
        Severity: Minor
        Found in integration/helpers/liquidity.ts and 2 other locations - About 30 mins to fix
        integration/helpers/liquidity.ts on lines 175..180
        integration/helpers/liquidity.ts on lines 181..186

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            await expect(page).toMatchElement(
      ".market-positions-list-styles_MarketPositionsList__table-body .market-positions-list--order-styles_Order:nth-child(" +
        row +
        ") li:nth-child(4)",
      { text: orders[i].price, timeout: timeoutMilliseconds }
        Severity: Minor
        Found in integration/helpers/liquidity.ts and 2 other locations - About 30 mins to fix
        integration/helpers/liquidity.ts on lines 157..162
        integration/helpers/liquidity.ts on lines 175..180

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 45.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status