Sign upLogin

AugurProject/augur-ui

View on GitHub
Star
src/modules/create-market/components/create-market-form/create-market-form.jsx

Summary

Maintainability
F
3 days
Test Coverage

File create-market-form.jsx has 422 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint react/no-array-index-key: 0 */ // It's OK in this specific instance as order remains the same

import React, { Component } from "react";
import PropTypes from "prop-types";
import classNames from "classnames";
Severity: Minor
Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 6 hrs to fix

    Function render has 147 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
    const {
      addOrderToNewMarket,
      availableEth,
      availableRep,
    Severity: Major
    Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 5 hrs to fix

      Function updateInitialLiquidityCosts has 50 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        updateInitialLiquidityCosts(order, shouldReduce) {
    const { availableEth, newMarket, updateNewMarket } = this.props;
    const minPrice = newMarket.type === SCALAR ? newMarket.scalarSmallNum : 0;
    const maxPrice = newMarket.type === SCALAR ? newMarket.scalarBigNum : 1;
    const shareBalances = newMarket.outcomes.map(outcome => 0);
      Severity: Minor
      Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 2 hrs to fix

        Function validateNumber has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          validateNumber(
    fieldName,
    rawValue,
    humanName,
    min,
        Severity: Minor
        Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 1 hr to fix

          Function processEndTime has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            static processEndTime(newMarket) {
    if (!newMarket.setEndTime) {
      return newMarket.endTime;
    }
          Severity: Minor
          Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 1 hr to fix

            Function processEndTime has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              static processEndTime(newMarket) {
    if (!newMarket.setEndTime) {
      return newMarket.endTime;
    }
            Severity: Minor
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function validateNumber has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              validateNumber(
    fieldName,
    rawValue,
    humanName,
    min,
            Severity: Minor
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function updateInitialLiquidityCosts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              updateInitialLiquidityCosts(order, shouldReduce) {
    const { availableEth, newMarket, updateNewMarket } = this.props;
    const minPrice = newMarket.type === SCALAR ? newMarket.scalarSmallNum : 0;
    const maxPrice = newMarket.type === SCALAR ? newMarket.scalarBigNum : 1;
    const shareBalances = newMarket.outcomes.map(outcome => 0);
            Severity: Minor
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            TODO found
            Open

                // TODO -- refactor this to derive route based on url path rather than state value
            Severity: Minor
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx by fixme

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                const {
      addOrderToNewMarket,
      availableEth,
      availableRep,
      categories,
            Severity: Major
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx and 3 other locations - About 2 hrs to fix
            src/modules/app/components/app/app.jsx on lines 515..530
            src/modules/market-charts/components/market-outcome-charts--candlestick/market-outcome-charts--candlestick.jsx on lines 170..185
            src/modules/trading/components/trading--wrapper/trading--wrapper.jsx on lines 184..199

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 82.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            <CreateMarketResolution
                  newMarket={newMarket}
                  updateNewMarket={updateNewMarket}
                  validateField={this.validateField}
                  isValid={this.isValid}
            Severity: Major
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx and 1 other location - About 1 hr to fix
            src/modules/create-market/components/create-market-form/create-market-form.jsx on lines 362..369

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            <CreateMarketOutcome
                  newMarket={newMarket}
                  updateNewMarket={updateNewMarket}
                  validateField={this.validateField}
                  isValid={this.isValid}
            Severity: Major
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx and 1 other location - About 1 hr to fix
            src/modules/create-market/components/create-market-form/create-market-form.jsx on lines 370..377

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 61.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                } else {
      initialLiquidityEth = newMarket.initialLiquidityEth.plus(
        action.tokensDepleted
      );
      initialLiquidityGas = newMarket.initialLiquidityGas.plus(
            Severity: Minor
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx and 1 other location - About 30 mins to fix
            src/modules/create-market/components/create-market-form/create-market-form.jsx on lines 287..294

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                  case maxLength && value.length > maxLength:
        updatedMarket.validations[currentStep][
          fieldName
        ] = `Maximum length is ${maxLength}.`;
        break;
            Severity: Minor
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx and 1 other location - About 30 mins to fix
            src/modules/create-market/components/create-market-form-define/create-market-form-define.jsx on lines 111..115

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                if (shouldReduce) {
      initialLiquidityEth = newMarket.initialLiquidityEth.minus(
        action.tokensDepleted
      );
      initialLiquidityGas = newMarket.initialLiquidityGas.minus(
            Severity: Minor
            Found in src/modules/create-market/components/create-market-form/create-market-form.jsx and 1 other location - About 30 mins to fix
            src/modules/create-market/components/create-market-form/create-market-form.jsx on lines 294..301

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status