File CreateTransactionSampleTest.cs
has 404 lines of code (exceeds 250 allowed). Consider refactoring. Open
using AuthorizeNet.Utility;
namespace AuthorizeNet.Api.Controllers.SampleTest
{
using System;
Method SampleCodeCreateTransactionUsingProfile
has 46 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public void SampleCodeCreateTransactionUsingProfile()
{
LogHelper.info(Logger, "Sample createTransaction using Profile");
Method SampleCodeCreateTransaction
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public void SampleCodeCreateTransaction()
{
LogHelper.info(Logger, "Sample createTransaction");
Method SampleCodeCreateTransactionPriorAuthCapture
has 41 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public void SampleCodeCreateTransactionPriorAuthCapture()
{
//Common code to set for all requests
ApiOperationBase<ANetApiRequest, ANetApiResponse>.MerchantAuthentication = CustomMerchantAuthenticationType;
Method SampleCodeCreateCreditRequestForSettledTransaction
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
[Ignore("Requires user to specify settled transaction")]
public void SampleCodeCreateCreditRequestForSettledTransaction()
{
var rnd = new AnetRandom(DateTime.Now.Millisecond);
Method createProfile
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
private Boolean createProfile(out String customerProfileId, out String paymentProfileId)
{
ApiOperationBase<ANetApiRequest, ANetApiResponse>.MerchantAuthentication = CustomMerchantAuthenticationType;
ApiOperationBase<ANetApiRequest, ANetApiResponse>.RunEnvironment = TestEnvironment;
Method TransactionRequest_HandleError
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public void TransactionRequest_HandleError()
{
LogHelper.info(Logger, "CreateProfileWithCreateTransactionRequestTest");
Method SampleCodeCreateTransactionWithVisaCheckOut
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
[Ignore("To run this test, use dataKey, dataValue, callId details and Merchant ApiLoginIdKey and TransactionKey to configure this test below.")]
public void SampleCodeCreateTransactionWithVisaCheckOut()
{
// The test setup.
Method SampleCodeCreateTransactionWithApplePay
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
[Ignore("To run this test, use your ApplePay ApiLoginIdKey and TransactionKey to configure this test below.")]
public void SampleCodeCreateTransactionWithApplePay()
{
// The test setup.
Identical blocks of code found in 3 locations. Consider refactoring. Open
if (0 == transId)
{
ValidateFailure<createTransactionRequest, createTransactionResponse, createTransactionController>(createController, createResponse);
Assert.IsNotNull(createResponse.transactionResponse.errors);
foreach (var error in createResponse.transactionResponse.errors)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 125.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 3 locations. Consider refactoring. Open
if (0 == transId)
{
ValidateFailure<createTransactionRequest, createTransactionResponse, createTransactionController>(createController, createResponse);
Assert.IsNotNull(createResponse.transactionResponse.errors);
foreach (var error in createResponse.transactionResponse.errors)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 125.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76