AuthorizeNet/sdk-java

View on GitHub
src/main/java/net/authorize/util/HttpClient.java

Summary

Maintainability
B
4 hrs
Test Coverage

Method getHttpsClient has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    static CloseableHttpClient getHttpsClient() throws Exception {
        SSLContext sslcontext = getSSLContext();
        try {
            LayeredConnectionSocketFactory sslSocketFactory = new org.apache.http.conn.ssl.SSLConnectionSocketFactory(
                    sslcontext, SSLConnectionSocketFactory.STRICT_HOSTNAME_VERIFIER);
Severity: Minor
Found in src/main/java/net/authorize/util/HttpClient.java - About 1 hr to fix

    Method convertStreamToString has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @Deprecated
        public static String convertStreamToString(InputStream is) {
            BufferedReader reader = new BufferedReader(new InputStreamReader(is));
            StringBuilder sb = new StringBuilder();
    
    Severity: Minor
    Found in src/main/java/net/authorize/util/HttpClient.java - About 1 hr to fix

      Method convertStreamToString has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          @Deprecated
          public static String convertStreamToString(InputStream is) {
              BufferedReader reader = new BufferedReader(new InputStreamReader(is));
              StringBuilder sb = new StringBuilder();
      
      Severity: Minor
      Found in src/main/java/net/authorize/util/HttpClient.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getHttpsClient has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          static CloseableHttpClient getHttpsClient() throws Exception {
              SSLContext sslcontext = getSSLContext();
              try {
                  LayeredConnectionSocketFactory sslSocketFactory = new org.apache.http.conn.ssl.SSLConnectionSocketFactory(
                          sslcontext, SSLConnectionSocketFactory.STRICT_HOSTNAME_VERIFIER);
      Severity: Minor
      Found in src/main/java/net/authorize/util/HttpClient.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status