Sign upLogin

AuthorizeNet/sdk-java

View on GitHub
Star
src/main/java/net/authorize/util/XmlUtility.java

Summary

Maintainability
C
1 day
Test Coverage

Method create has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public static synchronized <T extends Serializable> T create(String xml, Class<T> classType) throws JAXBException, ParserConfigurationException, SAXException
    {
        T entity = null;
Severity: Minor
Found in src/main/java/net/authorize/util/XmlUtility.java - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @SuppressWarnings("unchecked")
    public static synchronized <T extends Serializable> T create(String xml, Class<T> classType) throws JAXBException, ParserConfigurationException, SAXException
    {
        T entity = null;
Severity: Minor
Found in src/main/java/net/authorize/util/XmlUtility.java - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                                    if ( null != element.getValue() && element.getValue().getClass()==classType) {
                                    entity = (T) element.getValue();
                                }
    Severity: Major
    Found in src/main/java/net/authorize/util/XmlUtility.java - About 45 mins to fix

      Method escapeStringForXml has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public static String escapeStringForXml( String valueToSerialize) {
        String retVal = valueToSerialize;
        
        if ( null != valueToSerialize && valueToSerialize.length() > 0) { 
            try {
      Severity: Minor
      Found in src/main/java/net/authorize/util/XmlUtility.java - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method getXml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static synchronized <T extends Serializable> String getXml(T entity) throws IOException, JAXBException
    {
        StringWriter sw = new StringWriter();

        if ( null != entity)
      Severity: Minor
      Found in src/main/java/net/authorize/util/XmlUtility.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method descapeStringForXml has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static String descapeStringForXml(String valueToDeserialize) {
        String retVal = valueToDeserialize;
        
        if ( null != valueToDeserialize && valueToDeserialize.length() > 0)
        {
      Severity: Minor
      Found in src/main/java/net/authorize/util/XmlUtility.java - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status