AyuntamientoMadrid/participacion

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#legislation_proposals_list") do
        within all(".legislation_proposal")[0] { expect(page).to have_content("30") }
        within all(".legislation_proposal")[1] { expect(page).to have_content("20") }
        within all(".legislation_proposal")[2] { expect(page).to have_content("10") }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Ballot is not visible" do
      login_as(author)

      visit budget_investments_path(budget, heading_id: heading.id)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "assigns multiple targets" do
      relatable.related_sdg_list = "1.1,2.3"

      expect(relatable.reload.sdg_goals).to match_array [SDG::Goal[1], SDG::Goal[2]]
      expect(relatable.reload.sdg_targets).to match_array [SDG::Target[1.1], SDG::Target[2.3]]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#legislation_proposals_list") do
        within all(".legislation_proposal")[0] { expect(page).to have_content("aaaa") }
        within all(".legislation_proposal")[1] { expect(page).to have_content("bbbb") }
        within all(".legislation_proposal")[2] { expect(page).to have_content("cccc") }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    describe "#publishing_prices_or_later?" do
      it "returns false before publishing prices" do
        budget.phase = "valuating"
        expect(budget).not_to be_publishing_prices_or_later
      end

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe "valuation_finished" do
      it "returns investments with valuation finished" do
        investment = create(:budget_investment, valuation_finished: true)

        expect(Budget::Investment.valuation_finished).to eq [investment]

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it "does not include votes of hidden proposals" do
      create(:proposal, id: 1, voters: [create(:user)])
      create(:proposal, :hidden, id: 2, voters: [create(:user)])

      response = execute("{ votes { edges { node { votable_id } } } }")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def import_ml_proposals_comments_summary
      json_file = data_folder.join(MachineLearning.proposals_comments_summary_filename)
      json_data = JSON.parse(File.read(json_file)).each(&:deep_symbolize_keys!)
      json_data.each do |attributes|
        attributes.delete(:id)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Ballot is visible" do
      login_as(author)

      visit budget_investments_path(budget, heading_id: heading.id)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Can hide own proposal" do
    moderator = create(:moderator)
    proposal = create(:proposal, author: moderator.user)

    login_as(moderator.user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "uses the human name as default" do
        record = double(human_name: "Everywhere and nowhere")
        text = 'Are you sure? Edit "Everywhere and nowhere"'

        render_inline Admin::ActionComponent.new(:edit, record, path: "/", confirm: true)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it "does not include votes of hidden comments" do
      create(:comment, id: 1, voters: [create(:user)])
      create(:comment, :hidden, id: 2, voters: [create(:user)])

      response = execute("{ votes { edges { node { votable_id } } } }")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#budget-investments") do
        expect(page).to have_css(".budget-investment", count: 1)
        expect(page).to have_content(budget_investment1.title)
        expect(page).not_to have_content(budget_investment2.title)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#budget-investments") do
        expect(page).to have_css(".budget-investment", count: 1)
        expect(page).not_to have_content(budget_investment1.title)
        expect(page).to have_content(budget_investment2.title)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "includes a more detailed message for the destroy action" do
        record = double(human_name: "Participatory Budget 2015")
        text = 'Are you sure? This action will delete "Participatory Budget 2015" and can\\\'t be undone.'

        render_inline Admin::ActionComponent.new(:destroy, record, path: "/", confirm: true)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Can not hide own debate" do
    moderator = create(:moderator)
    debate = create(:debate, author: moderator.user)

    login_as(moderator.user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    def import_ml_investments_comments_summary
      json_file = data_folder.join(MachineLearning.investments_comments_summary_filename)
      json_data = JSON.parse(File.read(json_file)).each(&:deep_symbolize_keys!)
      json_data.each do |attributes|
        attributes.delete(:id)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "ignores trailing spaces and spaces between commas" do
      relatable.related_sdg_list = " 1.1,  2.3 "

      expect(relatable.reload.sdg_goals).to match_array [SDG::Goal[1], SDG::Goal[2]]
      expect(relatable.reload.sdg_targets).to match_array [SDG::Target[1.1], SDG::Target[2.3]]

• Read up
  Read up

Method build has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

  def self.build(commentable, user, body, p_id = nil, valuation = false)

Similar blocks of code found in 5 locations. Consider refactoring.

Open

  it "shows the officing link to poll officers" do
    user = create(:poll_officer).user

    render_inline Layout::AdminLoginItemsComponent.new(user)

• Read up
  Read up