AyuntamientoMadrid/participacion

Function draw has 71 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  ProposalGraph.prototype.draw = function() {
    var colors = {},
      maximumValue = this.maximumValue === 0 ? this.proposalSuccess : Math.round(this.maximumValue * 1.10);

    this.formatXColumnValues();

Class ProposalsController has 25 methods (exceeds 20 allowed). Consider refactoring.

Open

class ProposalsController < ApplicationController
  include FeatureFlags
  include CommentableActions
  include FlagActions
  include ImageAttributes

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#open?" do
    it "checks draft publication" do
      # future
      process.update!(draft_publication_date: Date.current + 2.days)
      expect(process.draft_publication.open?).to be false

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#started?" do
    it "checks draft publication" do
      # future
      process.update!(draft_publication_date: Date.current + 2.days)
      expect(process.draft_publication.started?).to be false

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  ProposalGraph.prototype.refreshData = function() {
    return $.ajax({
      url: this.url,
      cache: false,
      success: function(data) {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  ProposalGraph.prototype.refreshSuccessfulData = function() {
    return $.ajax({
      url: this.successfulProposalDataUrl,
      cache: false,
      success: function(data) {

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  ProposalGraph.prototype.refreshAchievements = function() {
    return $.ajax({
      url: this.proposalAchievementsUrl,
      cache: false,
      success: function(data) {

• Read up
  Read up

File admin.rb has 283 lines of code (exceeds 250 allowed). Consider refactoring.

Open

namespace :admin do
  root to: "dashboard#index"
  resources :organizations, only: :index do
    get :search, on: :collection
    member do

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      $("[data-check-all]").on("click", function(e) {
        var target_name;
        e.preventDefault();
        e.stopPropagation();
        target_name = $(this).data("check-all");

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      $("[data-check-none]").on("click", function(e) {
        var target_name;
        e.preventDefault();
        e.stopPropagation();
        target_name = $(this).data("check-none");

• Read up
  Read up

File settings_spec.rb has 281 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Admin settings", :admin do
  scenario "Index" do
    visit admin_settings_path

Function initializeMap has 68 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    initializeMap: function(element) {
      var createMarker, editable, investmentsMarkers, map, marker, markerClustering,
        markerData, markerIcon, markers, moveOrPlaceMarker, removeMarker, removeMarkerSelector;
      App.Map.cleanInvestmentCoordinates(element);
      removeMarkerSelector = $(element).data("marker-remove-selector");

File user_segments_spec.rb has 280 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe UserSegments do
  let(:user1) { create(:user) }
  let(:user2) { create(:user) }

File votes_spec.rb has 278 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Votes" do
  let!(:verified)   { create(:user, verified_at: Time.current) }
  let!(:unverified) { create(:user) }

File activity_spec.rb has 277 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Admin activity" do
  let(:admin) { create(:administrator) }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe "#next_phase_dates_valid?" do
      let(:error) do
        "End date must be earlier than the end date of the next enabled phase (Accepting projects)"
      end

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  context "Poll comments" do
    let(:user) { create(:user, email_on_comment: true) }
    let(:poll) { create(:poll, author: user) }

    scenario "Send email on poll comment" do

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  context "Proposal comments" do
    let(:user)     { create(:user, email_on_comment: true) }
    let(:proposal) { create(:proposal, author: user) }

    scenario "Send email on proposal comment" do

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe "#prev_phase_dates_valid?" do
      let(:error) do
        "Start date must be later than the start date of the previous enabled phase (Information)"
      end

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  context "Debate comments" do
    let(:user)   { create(:user, email_on_comment: true) }
    let(:debate) { create(:debate, author: user) }

    scenario "Send email on debate comment" do

• Read up
  Read up