Sign upLogin

AyuntamientoMadrid/participacion

View on GitHub
Star
spec/models/legislation/annotation_spec.rb

Summary

Maintainability
A
1 hr
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it "calculates the context for multinode annotations 2" do
    quote = "Duis autem vel eum iriure dolor in hendrerit in vulputate velit esse " \
            "molestie consequat, vel illum dolore eu feugiat nulla facilisis at vero " \
            "eros et accumsan et iusto odio dignissim qui blandit praesent luptatum " \
            "zzril delenit augue duis dolore te feugait nulla facilisi.\r\n\r\n" \
Severity: Minor
Found in spec/models/legislation/annotation_spec.rb and 1 other location - About 30 mins to fix
spec/models/legislation/annotation_spec.rb on lines 12..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  it "calculates the context for multinode annotations" do
    quote = "ipsum dolor sit amet, consectetuer adipiscing elit, sed diam nonummy nibh " \
            "euismod tincidunt ut laoreet dolore magna aliquam erat volutpat. Ut wisi " \
            "enim ad minim veniam, quis nostrud exerci tation ullamcorper suscipit " \
            "lobortis nisl ut aliquip ex ea commodo consequat. Duis autem vel eum " \
Severity: Minor
Found in spec/models/legislation/annotation_spec.rb and 1 other location - About 30 mins to fix
spec/models/legislation/annotation_spec.rb on lines 57..88

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 33.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status