AyuntamientoMadrid/participacion

File proposal_spec.rb has 817 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe Proposal do
  let(:proposal) { build(:proposal) }

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#hot_score" do
    let(:now) { Time.current }

    it "period is correctly calculated to get exact votes per day" do
      new_proposal = create(:proposal, created_at: 23.hours.ago)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "reorder" do
      it "is able to reorder by hot_score after searching" do
        lowest_score  = create(:proposal,  title: "stop corruption", cached_votes_up: 1)
        highest_score = create(:proposal,  title: "stop corruption", cached_votes_up: 2)
        average_score = create(:proposal,  title: "stop corruption", cached_votes_up: 3)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "no results" do
      it "no words match" do
        create(:proposal, title: "save world")

        results = Proposal.search("destroy planet")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#editable?" do
    let(:proposal) { create(:proposal) }

    before { Setting["max_votes_for_proposal_edit"] = 5 }

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  describe "milestone_tags" do
    context "without milestone_tags" do
      let(:proposal) { create(:proposal) }

      it "do not have milestone_tags" do

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "accents" do
      it "searches with accents" do
        proposal = create(:proposal, summary: "difusión")

        results = Proposal.search("difusion")

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  describe "archived" do
    let!(:new_proposal)      { create(:proposal) }
    let!(:archived_proposal) { create(:proposal, :archived) }

    it "archived? is true only for proposals created more than n (configured months) ago" do

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  describe "selected" do
    let!(:not_selected_proposal) { create(:proposal) }
    let!(:selected_proposal)     { create(:proposal, :selected) }

    it "selected? is true" do

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  describe "retired" do
    let!(:proposal1) { create(:proposal) }
    let!(:proposal2) { create(:proposal, :retired) }

    it "retired? is true" do

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "orders by weight and then by votes" do
        title_some_votes   = create(:proposal, title: "stop corruption", cached_votes_up: 5)
        title_least_voted  = create(:proposal, title: "stop corruption", cached_votes_up: 2)
        title_most_voted   = create(:proposal, title: "stop corruption", cached_votes_up: 10)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "returns proposals related to the user's interests ordered by cached_votes_up" do
      create(:proposal, tag_list: "Sport", followers: [user])

      proposal1 = create(:proposal, cached_votes_up: 1,  tag_list: "Sport")
      proposal2 = create(:proposal, cached_votes_up: 5,  tag_list: "Sport")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "custom tag counters when hiding/restoring" do
    it "decreases the tag counter when hiden, and increases it when restored" do
      proposal = create(:proposal, tag_list: "foo")
      tag = Tag.find_by(name: "foo")
      expect(tag.proposals_count).to eq(1)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  describe "#title" do
    it "is not valid without a title" do
      proposal.title = nil
      expect(proposal).not_to be_valid
    end

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "case" do
      it "searches case insensitive" do
        proposal = create(:proposal, title: "SHOUT")

        results = Proposal.search("shout")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "tag_list" do
    it "is not valid with a tag list of more than 6 elements" do
      proposal.tag_list = ["Hacienda", "Economía", "Medio Ambiente", "Corrupción",
                           "Fiestas populares", "Prensa", "Huelgas"]
      expect(proposal).not_to be_valid

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "send notification after published when there are new actived actions" do
      create(:dashboard_action, :proposed_action, :active, day_offset: 0, published_proposal: true)
      create(:dashboard_action, :resource, :active, day_offset: 0, published_proposal: true)

      proposal = create(:proposal, :draft)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "Not send notification after published when there are not new actived actions" do
      create(:dashboard_action, :proposed_action, :active, day_offset: 1, published_proposal: true)
      create(:dashboard_action, :resource, :active, day_offset: 1, published_proposal: true)

      proposal = create(:proposal, :draft)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "send notification after create when there are new actived actions" do
      create(:dashboard_action, :proposed_action, :active, day_offset: 0, published_proposal: false)
      create(:dashboard_action, :resource, :active, day_offset: 0, published_proposal: false)

      create(:proposal, :draft)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "Not send notification after create when there are not new actived actions" do
      create(:dashboard_action, :proposed_action, :active, day_offset: 1, published_proposal: false)
      create(:dashboard_action, :resource, :active, day_offset: 1, published_proposal: false)

      create(:proposal, :draft)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "tags" do
      it "searches by tags" do
        proposal = create(:proposal, tag_list: "Latina")

        results = Proposal.search("Latina")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "does not return users that have been erased" do
      proposal = create(:proposal)
      voter1 = create(:user, :level_two, votables: [proposal])
      voter2 = create(:user, :level_two, votables: [proposal])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "does not return users that have been blocked" do
      proposal = create(:proposal)
      voter1 = create(:user, :level_two, votables: [proposal])
      voter2 = create(:user, :level_two, votables: [proposal])

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "gives much more weight to word matches than votes" do
        exact_title_few_votes    = create(:proposal, title: "stop corruption", cached_votes_up: 5)
        similar_title_many_votes = create(:proposal, title: "stop some of the corruption",
                                                     cached_votes_up: 500)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "public_for_api scope" do
    it "returns proposals" do
      proposal = create(:proposal)

      expect(Proposal.public_for_api).to eq [proposal]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "registers vote" do
        user = create(:user, residence_verified_at: Time.current, confirmed_phone: "666333111")
        expect { proposal.register_vote(user, "yes") }.to change { proposal.reload.votes_for.size }.by(1)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "does not return proposals when user is the author" do
      create(:proposal, tag_list: "Sport", followers: [user])
      create(:proposal, author: user, tag_list: "Sport")

      results = Proposal.recommendations(user)

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      it "searches by geozone" do
        geozone = create(:geozone, name: "California")
        proposal = create(:proposal, geozone: geozone)
        results = Proposal.search("California")
        expect(results).to eq([proposal])

• Read up
  Read up

Similar blocks of code found in 4 locations. Consider refactoring.

Open

      it "searches by author name" do
        author = create(:user, username: "Danny Trejo")
        proposal = create(:proposal, author: author)
        results = Proposal.search("Danny")
        expect(results).to eq([proposal])

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    it "expires cache when the author's organization get verified" do
      create(:organization, user: proposal.author)
      expect { proposal.author.organization.verify }
        .to change { [proposal.reload.cache_version, proposal.author.cache_version] }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  describe "#video_url" do
    it "is not valid when URL is not from Youtube or Vimeo" do
      proposal.video_url = "https://twitter.com"
      expect(proposal).not_to be_valid
    end

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "registers vote" do
        user = create(:user, verified_at: Time.current)
        expect { proposal.register_vote(user, "yes") }.to change { proposal.reload.votes_for.size }.by(1)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "does not return proposals unrelated to user interests" do
      create(:proposal, tag_list: "Sport", followers: [user])
      create(:proposal, tag_list: "Politics")

      results = Proposal.recommendations(user)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    it "returns proposals created this week" do
      create(:tag, :category, name: "culture")
      proposal = create(:proposal, tag_list: "culture")

      expect(Proposal.for_summary.values.flatten).to eq [proposal]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      it "returns proposals tagged with a category" do
        create(:tag, :category, name: "culture")
        proposal = create(:proposal, tag_list: "culture")

        expect(Proposal.for_summary.values.flatten).to eq [proposal]

• Read up
  Read up