AyuntamientoMadrid/participacion

File budget_investments_spec.rb has 1432 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Admin budget investments", :admin do
  let(:budget) { create(:budget) }
  let(:administrator) do

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Filtering by minimum number of votes" do
      group_1 = create(:budget_group, budget: budget)
      group_2 = create(:budget_group, budget: budget)
      parks   = create(:budget_heading, group: group_1)
      roads   = create(:budget_heading, group: group_2)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Filtering by maximum number of votes" do
      group_1 = create(:budget_group, budget: budget)
      group_2 = create(:budget_group, budget: budget)
      parks   = create(:budget_heading, group: group_1)
      roads   = create(:budget_heading, group: group_2)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "Ascending" do
      scenario "Sort by ID" do
        visit admin_budget_budget_investments_path(budget, sort_by: "id", direction: "asc")

        expect("B First Investment").to appear_before("A Second Investment")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    context "Descending" do
      scenario "Sort by ID" do
        visit admin_budget_budget_investments_path(budget, sort_by: "id", direction: "desc")

        expect("C Third Investment").to appear_before("A Second Investment")

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    scenario "Filtering by without assigned valuator" do
      create(:budget_investment, title: "Investment without valuator", budget: budget)
      create(:budget_investment, :with_valuator, title: "Investment with valuator", budget: budget)

      visit admin_budget_budget_investments_path(budget_id: budget)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    scenario "Filtering by without assigned admin" do
      create(:budget_investment, title: "Investment without admin", budget: budget)
      create(:budget_investment, :with_administrator, title: "Investment with admin", budget: budget)

      visit admin_budget_budget_investments_path(budget_id: budget)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

    scenario "Filtering by valuation finished" do
      create(:budget_investment, title: "Investment valuation open", budget: budget)
      create(:budget_investment, :finished, title: "Investment valuation finished", budget: budget)

      visit admin_budget_budget_investments_path(budget_id: budget)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      scenario "Sort by supports" do
        visit admin_budget_budget_investments_path(budget, sort_by: "supports")

        expect("C Third Investment").to appear_before("A Second Investment")
        expect("A Second Investment").to appear_before("B First Investment")

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      scenario "Sort by title" do
        visit admin_budget_budget_investments_path(budget, sort_by: "title")

        expect("A Second Investment").to appear_before("B First Investment")
        expect("B First Investment").to appear_before("C Third Investment")

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      scenario "Sort by ID" do
        visit admin_budget_budget_investments_path(budget, sort_by: "id")

        expect("B First Investment").to appear_before("A Second Investment")
        expect("A Second Investment").to appear_before("C Third Investment")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#budget_investment_#{budget_investment2.id}") do
        expect(page).to have_content("No admin assigned")
        expect(page).to have_content("Valuator Olga")
        expect(page).to have_content("Valuator Miriam")
        expect(page).to have_content("Health")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#tags_budget_investment_#{budget_investment.id}") do
        expect(page).not_to have_content "Education"
        expect(page).not_to have_content "Environment"
        expect(page).to have_content "Park"
        expect(page).to have_content "Trees"

• Read up
  Read up