AyuntamientoMadrid/participacion

View on GitHub
spec/system/comments/legislation_annotations_spec.rb

Summary

Maintainability
D
2 days
Test Coverage
require "rails_helper"

describe "Commenting legislation questions" do
  let(:user) { create :user }
  let(:legislation_annotation) { create :legislation_annotation, author: user }

  it_behaves_like "flaggable", :legislation_annotation_comment

  scenario "Index" do
    3.times { create(:comment, commentable: legislation_annotation) }
    comment = Comment.includes(:user).last

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    expect(page).to have_css(".comment", count: 4)

    within first(".comment") do
      expect(page).to have_content comment.user.name
      expect(page).to have_content I18n.l(comment.created_at, format: :datetime)
      expect(page).to have_content comment.body
    end
  end

  scenario "Show" do
    href           = legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                                       legislation_annotation.draft_version,
                                                                       legislation_annotation)
    parent_comment = create(:comment, commentable: legislation_annotation, body: "Parent")
    create(:comment, commentable: legislation_annotation, parent: parent_comment, body: "First subcomment")
    create(:comment, commentable: legislation_annotation, parent: parent_comment, body: "Last subcomment")

    visit comment_path(parent_comment)

    expect(page).to have_css(".comment", count: 3)
    expect(page).to have_content "Parent"
    expect(page).to have_content "First subcomment"
    expect(page).to have_content "Last subcomment"

    expect(page).to have_link "Go back to #{legislation_annotation.title}", href: href

    within ".comment", text: "Parent" do
      expect(page).to have_selector(".comment", count: 2)
    end
  end

  scenario "Link to comment show" do
    comment = create(:comment, commentable: legislation_annotation, user: user)

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    within "#comment_#{comment.id}" do
      expect(page).to have_link comment.created_at.strftime("%Y-%m-%d %T")
      click_link comment.created_at.strftime("%Y-%m-%d %T")
    end

    expect(page).to have_link "Go back to #{legislation_annotation.title}"
    expect(page).to have_current_path(comment_path(comment))
  end

  scenario "Collapsable comments" do
    parent_comment = legislation_annotation.comments.first
    child_comment  = create(:comment, body: "First subcomment", commentable: legislation_annotation, parent: parent_comment)
    grandchild_comment = create(:comment, body: "Last subcomment", commentable: legislation_annotation, parent: child_comment)

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    expect(page).to have_css(".comment", count: 3)
    expect(page).to have_content("1 response (collapse)", count: 2)

    within ".comment .comment", text: "First subcomment" do
      click_link text: "1 response (collapse)"
    end

    expect(page).to have_css(".comment", count: 2)
    expect(page).to have_content("1 response (collapse)")
    expect(page).to have_content("1 response (show)")
    expect(page).not_to have_content grandchild_comment.body

    within ".comment .comment", text: "First subcomment" do
      click_link text: "1 response (show)"
    end

    expect(page).to have_css(".comment", count: 3)
    expect(page).to have_content("1 response (collapse)", count: 2)
    expect(page).to have_content grandchild_comment.body

    within ".comment", text: parent_comment.body do
      click_link text: "1 response (collapse)", match: :first
    end

    expect(page).to have_css(".comment", count: 1)
    expect(page).to have_content("1 response (show)")
    expect(page).not_to have_content child_comment.body
    expect(page).not_to have_content grandchild_comment.body
  end

  scenario "Comment order" do
    c1 = create(:comment, :with_confidence_score, commentable: legislation_annotation, cached_votes_up: 100,
                                                  cached_votes_total: 120, created_at: Time.current - 2)
    c2 = create(:comment, :with_confidence_score, commentable: legislation_annotation, cached_votes_up: 10,
                                                  cached_votes_total: 12, created_at: Time.current - 1)
    c3 = create(:comment, :with_confidence_score, commentable: legislation_annotation, cached_votes_up: 1,
                                                  cached_votes_total: 2, created_at: Time.current)

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation,
                                                            order: :most_voted)

    expect(c1.body).to appear_before(c2.body)
    expect(c2.body).to appear_before(c3.body)

    click_link "Newest first"

    expect(page).to have_link "Newest first", class: "is-active"
    expect(page).to have_current_path(/#comments/, url: true)
    expect(c3.body).to appear_before(c2.body)
    expect(c2.body).to appear_before(c1.body)

    click_link "Oldest first"

    expect(page).to have_link "Oldest first", class: "is-active"
    expect(page).to have_current_path(/#comments/, url: true)
    expect(c1.body).to appear_before(c2.body)
    expect(c2.body).to appear_before(c3.body)
  end

  scenario "Creation date works differently in roots and in child comments, even when sorting by confidence_score" do
    old_root = create(:comment, commentable: legislation_annotation, created_at: Time.current - 10)
    new_root = create(:comment, commentable: legislation_annotation, created_at: Time.current)
    old_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current - 10)
    new_child = create(:comment, commentable: legislation_annotation, parent_id: new_root.id, created_at: Time.current)

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation,
                                                            order: :most_voted)

    expect(new_root.body).to appear_before(old_root.body)
    expect(old_child.body).to appear_before(new_child.body)

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation,
                                                            order: :newest)

    expect(new_root.body).to appear_before(old_root.body)
    expect(new_child.body).to appear_before(old_child.body)

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation,
                                                            order: :oldest)

    expect(old_root.body).to appear_before(new_root.body)
    expect(old_child.body).to appear_before(new_child.body)
  end

  scenario "Turns links into html links" do
    legislation_annotation = create :legislation_annotation, author: user
    legislation_annotation.comments << create(:comment, body: "Built with http://rubyonrails.org/")

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    within all(".comment").first do
      expect(page).to have_content "Built with http://rubyonrails.org/"
      expect(page).to have_link("http://rubyonrails.org/", href: "http://rubyonrails.org/")
      expect(find_link("http://rubyonrails.org/")[:rel]).to eq("nofollow")
      expect(find_link("http://rubyonrails.org/")[:target]).to eq("_blank")
    end
  end

  scenario "Sanitizes comment body for security" do
    create :comment, commentable: legislation_annotation,
                     body: "<script>alert('hola')</script> <a href=\"javascript:alert('sorpresa!')\">click me<a/> http://www.url.com"

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    within all(".comment").first do
      expect(page).to have_content "click me http://www.url.com"
      expect(page).to have_link("http://www.url.com", href: "http://www.url.com")
      expect(page).not_to have_link("click me")
    end
  end

  scenario "Paginated comments" do
    per_page = 10
    (per_page + 2).times { create(:comment, commentable: legislation_annotation) }

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    expect(page).to have_css(".comment", count: per_page)
    within("ul.pagination") do
      expect(page).to have_content("1")
      expect(page).to have_content("2")
      expect(page).not_to have_content("3")
      click_link "Next", exact: false
    end

    expect(page).to have_css(".comment", count: 3)
    expect(page).to have_current_path(/#comments/, url: true)
  end

  describe "Not logged user" do
    scenario "can not see comments forms" do
      create(:comment, commentable: legislation_annotation)
      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                              legislation_annotation.draft_version,
                                                              legislation_annotation)

      expect(page).to have_content "You must sign in or sign up to leave a comment"
      within("#comments") do
        expect(page).not_to have_content "Write a comment"
        expect(page).not_to have_content "Reply"
      end
    end
  end

  scenario "Create" do
    login_as(user)
    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    fill_in "Leave your comment", with: "Have you thought about...?"
    click_button "Publish comment"

    within "#comments" do
      expect(page).to have_content "Have you thought about...?"
      expect(page).to have_content "(2)"
    end
  end

  scenario "Errors on create" do
    login_as(user)
    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    click_button "Publish comment"

    expect(page).to have_content "Can't be blank"
  end

  scenario "Comments are disabled when the allegations phase is closed" do
    process = create(:legislation_process,
                     allegations_start_date: 1.month.ago,
                     allegations_end_date: Date.yesterday)

    version = create(:legislation_draft_version, process: process)
    annotation = create(:legislation_annotation, draft_version: version, text: "One annotation")

    login_as(user)

    visit legislation_process_draft_version_annotation_path(version.process, version, annotation)

    within "#comments" do
      expect(page).to have_content "Comments are closed"
      expect(page).not_to have_content "Leave your comment"
      expect(page).not_to have_button "Publish comment"
    end
  end

  scenario "Reply" do
    citizen = create(:user, username: "Ana")
    manuela = create(:user, username: "Manuela")
    legislation_annotation = create(:legislation_annotation, author: citizen)
    comment = legislation_annotation.comments.first

    login_as(manuela)
    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    click_link "Reply"

    within "#js-comment-form-comment_#{comment.id}" do
      fill_in "Leave your comment", with: "It will be done next week."
      click_button "Publish reply"
    end

    within "#comment_#{comment.id}" do
      expect(page).to have_content "It will be done next week."
    end

    expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}")
  end

  scenario "Reply update parent comment responses count" do
    manuela = create(:user, :level_two, username: "Manuela")
    legislation_annotation = create(:legislation_annotation)
    comment = legislation_annotation.comments.first

    login_as(manuela)
    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    within ".comment", text: comment.body do
      click_link "Reply"
      fill_in "Leave your comment", with: "It will be done next week."
      click_button "Publish reply"

      expect(page).to have_content("1 response (collapse)")
    end
  end

  scenario "Reply show parent comments responses when hidden" do
    manuela = create(:user, :level_two, username: "Manuela")
    legislation_annotation = create(:legislation_annotation)
    comment = legislation_annotation.comments.first
    create(:comment, commentable: legislation_annotation, parent: comment)

    login_as(manuela)
    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    within ".comment", text: comment.body do
      click_link text: "1 response (collapse)"
      click_link "Reply"
      fill_in "Leave your comment", with: "It will be done next week."
      click_button "Publish reply"

      expect(page).to have_content("It will be done next week.")
    end
  end

  scenario "Errors on reply" do
    comment = legislation_annotation.comments.first

    login_as(user)
    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    click_link "Reply"

    within "#js-comment-form-comment_#{comment.id}" do
      click_button "Publish reply"
      expect(page).to have_content "Can't be blank"
    end
  end

  scenario "N replies" do
    parent = create(:comment, commentable: legislation_annotation)

    7.times do
      create(:comment, commentable: legislation_annotation, parent: parent)
      parent = parent.children.first
    end

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    expect(page).to have_css(".comment.comment.comment.comment.comment.comment.comment.comment")
  end

  scenario "Erasing a comment's author" do
    legislation_annotation = create(:legislation_annotation)
    comment = create(:comment, commentable: legislation_annotation, body: "this should be visible")
    comment.user.erase

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    within "#comment_#{comment.id}" do
      expect(page).to have_content("User deleted")
      expect(page).to have_content("this should be visible")
    end
  end

  scenario "Submit button is disabled after clicking" do
    legislation_annotation = create(:legislation_annotation)
    login_as(user)

    visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                            legislation_annotation.draft_version,
                                                            legislation_annotation)

    fill_in "Leave your comment", with: "Testing submit button!"
    click_button "Publish comment"

    expect(page).to have_button "Publish comment", disabled: true
    expect(page).to have_content "Testing submit button!"
    expect(page).to have_button "Publish comment", disabled: false
  end

  describe "Moderators" do
    scenario "can create comment as a moderator" do
      moderator = create(:moderator)

      login_as(moderator.user)
      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                              legislation_annotation.draft_version,
                                                              legislation_annotation)

      fill_in "Leave your comment", with: "I am moderating!"
      check "comment-as-moderator-legislation_annotation_#{legislation_annotation.id}"
      click_button "Publish comment"

      within "#comments" do
        expect(page).to have_content "I am moderating!"
        expect(page).to have_content "Moderator ##{moderator.id}"
        expect(page).to have_css "div.is-moderator"
        expect(page).to have_css "img.moderator-avatar"
      end
    end

    scenario "can create reply as a moderator" do
      citizen = create(:user, username: "Ana")
      manuela = create(:user, username: "Manuela")
      moderator = create(:moderator, user: manuela)
      legislation_annotation = create(:legislation_annotation, author: citizen)
      comment = legislation_annotation.comments.first

      login_as(manuela)
      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                              legislation_annotation.draft_version,
                                                              legislation_annotation)

      click_link "Reply"

      within "#js-comment-form-comment_#{comment.id}" do
        fill_in "Leave your comment", with: "I am moderating!"
        check "comment-as-moderator-comment_#{comment.id}"
        click_button "Publish reply"
      end

      within "#comment_#{comment.id}" do
        expect(page).to have_content "I am moderating!"
        expect(page).to have_content "Moderator ##{moderator.id}"
        expect(page).to have_css "div.is-moderator"
        expect(page).to have_css "img.moderator-avatar"
      end

      expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}")
    end

    scenario "can not comment as an administrator" do
      moderator = create(:moderator)

      login_as(moderator.user)
      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                              legislation_annotation.draft_version,
                                                              legislation_annotation)

      expect(page).not_to have_content "Comment as administrator"
    end
  end

  describe "Administrators" do
    scenario "can create comment as an administrator" do
      admin = create(:administrator)

      login_as(admin.user)
      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                              legislation_annotation.draft_version,
                                                              legislation_annotation)

      fill_in "Leave your comment", with: "I am your Admin!"
      check "comment-as-administrator-legislation_annotation_#{legislation_annotation.id}"
      click_button "Publish comment"

      within "#comments" do
        expect(page).to have_content "I am your Admin!"
        expect(page).to have_content "Administrator ##{admin.id}"
        expect(page).to have_css "div.is-admin"
        expect(page).to have_css "img.admin-avatar"
      end
    end

    scenario "can create reply as an administrator" do
      citizen = create(:user, username: "Ana")
      manuela = create(:user, username: "Manuela")
      admin   = create(:administrator, user: manuela)
      legislation_annotation = create(:legislation_annotation, author: citizen)
      comment = legislation_annotation.comments.first

      login_as(manuela)
      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                              legislation_annotation.draft_version,
                                                              legislation_annotation)

      click_link "Reply"

      within "#js-comment-form-comment_#{comment.id}" do
        fill_in "Leave your comment", with: "Top of the world!"
        check "comment-as-administrator-comment_#{comment.id}"
        click_button "Publish reply"
      end

      within "#comment_#{comment.id}" do
        expect(page).to have_content "Top of the world!"
        expect(page).to have_content "Administrator ##{admin.id}"
        expect(page).to have_css "div.is-admin"
        expect(page).to have_css "img.admin-avatar"
      end

      expect(page).not_to have_selector("#js-comment-form-comment_#{comment.id}")
    end

    scenario "can not comment as a moderator", :admin do
      visit legislation_process_draft_version_annotation_path(legislation_annotation.draft_version.process,
                                                              legislation_annotation.draft_version,
                                                              legislation_annotation)

      expect(page).not_to have_content "Comment as moderator"
    end
  end

  describe "Voting comments" do
    let(:verified)   { create(:user, verified_at: Time.current) }
    let(:unverified) { create(:user) }
    let(:annotation) { create(:legislation_annotation) }
    let!(:comment)   { create(:comment, commentable: annotation) }

    before do
      login_as(verified)
    end

    scenario "Show" do
      create(:vote, voter: verified, votable: comment, vote_flag: true)
      create(:vote, voter: unverified, votable: comment, vote_flag: false)

      visit legislation_process_draft_version_annotation_path(annotation.draft_version.process,
                                                              annotation.draft_version,
                                                              annotation)

      within("#comment_#{comment.id}_votes") do
        within(".in-favor") do
          expect(page).to have_content "1"
        end

        within(".against") do
          expect(page).to have_content "1"
        end

        expect(page).to have_content "2 votes"
      end
    end

    scenario "Create" do
      visit legislation_process_draft_version_annotation_path(annotation.draft_version.process,
                                                              annotation.draft_version,
                                                              annotation)

      within("#comment_#{comment.id}_votes") do
        click_button "I agree"

        within(".in-favor") do
          expect(page).to have_content "1"
        end

        within(".against") do
          expect(page).to have_content "0"
        end

        expect(page).to have_content "1 vote"
      end
    end

    scenario "Update" do
      visit legislation_process_draft_version_annotation_path(annotation.draft_version.process,
                                                              annotation.draft_version,
                                                              annotation)

      within("#comment_#{comment.id}_votes") do
        click_button "I agree"

        within(".in-favor") do
          expect(page).to have_content "1"
        end

        click_button "I disagree"

        within(".in-favor") do
          expect(page).to have_content "0"
        end

        within(".against") do
          expect(page).to have_content "1"
        end

        expect(page).to have_content "1 vote"
      end
    end

    scenario "Trying to vote multiple times" do
      visit legislation_process_draft_version_annotation_path(annotation.draft_version.process,
                                                              annotation.draft_version,
                                                              annotation)

      within("#comment_#{comment.id}_votes") do
        click_button "I agree"
        within(".in-favor") do
          expect(page).to have_content "1"
        end

        click_button "I agree"
        within(".in-favor") do
          expect(page).not_to have_content "2"
          expect(page).to have_content "1"
        end

        within(".against") do
          expect(page).to have_content "0"
        end

        expect(page).to have_content "1 vote"
      end
    end
  end

  describe "Merged comment threads" do
    let!(:draft_version) { create(:legislation_draft_version, :published) }
    let!(:annotation1) do
      create(:legislation_annotation, draft_version: draft_version, text: "my annotation",
                                      ranges: [{ "start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 5 }])
    end
    let!(:annotation2) do
      create(:legislation_annotation, draft_version: draft_version, text: "my other annotation",
                                      ranges: [{ "start" => "/p[1]", "startOffset" => 1, "end" => "/p[1]", "endOffset" => 10 }])
    end
    let!(:comment1) { annotation1.comments.first }
    let!(:comment2) { annotation2.comments.first }

    before do
      login_as user

      visit legislation_process_draft_version_path(draft_version.process, draft_version)

      expect(page).to have_css ".annotator-hl"
      first(:css, ".annotator-hl").click

      within(".comment-box") do
        expect(page).to have_content "my annotation"
        expect(page).to have_content "my other annotation"
      end
    end

    scenario "View comments of annotations in an included range" do
      within("#annotation-link") do
        find(".icon-expand").click
      end

      expect(page).to have_css(".comment", count: 2)
      expect(page).to have_content("my annotation")
      expect(page).to have_content("my other annotation")
    end

    scenario "Reply on a single annotation thread and display it in the merged annotation thread" do
      within(".comment-box #annotation-#{annotation1.id}-comments") do
        first(:link, "0 replies").click
      end

      click_link "Reply"

      within "#js-comment-form-comment_#{comment1.id}" do
        fill_in "Leave your comment", with: "replying in single annotation thread"
        click_button "Publish reply"
      end

      within "#comment_#{comment1.id}" do
        expect(page).to have_content "replying in single annotation thread"
      end

      visit legislation_process_draft_version_path(draft_version.process, draft_version)

      expect(page).to have_css ".annotator-hl"
      first(:css, ".annotator-hl").click

      within(".comment-box") do
        expect(page).to have_content "my annotation"
        expect(page).to have_content "my other annotation"
      end

      within("#annotation-link") do
        find(".icon-expand").click
      end

      expect(page).to have_css(".comment", count: 3)
      expect(page).to have_content("my annotation")
      expect(page).to have_content("my other annotation")
      expect(page).to have_content("replying in single annotation thread")
    end

    scenario "Reply on a multiple annotation thread and display it in the single annotation thread" do
      within("#annotation-link") do
        find(".icon-expand").click
      end

      within("#comment_#{comment2.id}") do
        click_link "Reply"
      end

      within "#js-comment-form-comment_#{comment2.id}" do
        fill_in "Leave your comment", with: "replying in multiple annotation thread"
        click_button "Publish reply"
      end

      within "#comment_#{comment2.id}" do
        expect(page).to have_content "replying in multiple annotation thread"
      end

      visit legislation_process_draft_version_path(draft_version.process, draft_version)

      expect(page).to have_css ".annotator-hl"
      first(:css, ".annotator-hl").click

      within(".comment-box #annotation-#{annotation2.id}-comments") do
        first(:link, "1 reply").click
      end

      expect(page).to have_css(".comment", count: 2)
      expect(page).to have_content("my other annotation")
      expect(page).to have_content("replying in multiple annotation thread")
    end
  end
end