Sign upLogin

AyuntamientoMadrid/participacion

View on GitHub
Star
spec/system/officing_spec.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    in_browser(:two) do
      expect(page).to have_content("Here you can validate user documents and store voting results")

      visit new_officing_residence_path
      expect(page).to have_css "#residence_document_type"
Severity: Major
Found in spec/system/officing_spec.rb and 1 other location - About 1 hr to fix
spec/system/officing_spec.rb on lines 127..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    in_browser(:one) do
      expect(page).to have_content("Here you can validate user documents and store voting results")

      visit new_officing_residence_path
      expect(page).to have_css "#residence_document_type"
Severity: Major
Found in spec/system/officing_spec.rb and 1 other location - About 1 hr to fix
spec/system/officing_spec.rb on lines 150..170

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

  scenario "Access as manager is not authorized" do
    create(:manager, user: user)
    login_as(user)

    visit officing_root_path
Severity: Major
Found in spec/system/officing_spec.rb and 16 other locations - About 20 mins to fix
spec/system/admin_spec.rb on lines 15..22
spec/system/admin_spec.rb on lines 25..32
spec/system/admin_spec.rb on lines 35..42
spec/system/admin_spec.rb on lines 45..52
spec/system/moderation_spec.rb on lines 16..24
spec/system/moderation_spec.rb on lines 27..35
spec/system/moderation_spec.rb on lines 38..46
spec/system/moderation_spec.rb on lines 49..57
spec/system/officing_spec.rb on lines 17..25
spec/system/officing_spec.rb on lines 51..59
spec/system/officing_spec.rb on lines 62..70
spec/system/sdg_management_spec.rb on lines 19..27
spec/system/valuation_spec.rb on lines 17..25
spec/system/valuation_spec.rb on lines 28..36
spec/system/valuation_spec.rb on lines 39..47
spec/system/valuation_spec.rb on lines 50..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

  scenario "Access as moderator is not authorized" do
    create(:moderator, user: user)
    login_as(user)

    visit officing_root_path
Severity: Major
Found in spec/system/officing_spec.rb and 16 other locations - About 20 mins to fix
spec/system/admin_spec.rb on lines 15..22
spec/system/admin_spec.rb on lines 25..32
spec/system/admin_spec.rb on lines 35..42
spec/system/admin_spec.rb on lines 45..52
spec/system/moderation_spec.rb on lines 16..24
spec/system/moderation_spec.rb on lines 27..35
spec/system/moderation_spec.rb on lines 38..46
spec/system/moderation_spec.rb on lines 49..57
spec/system/officing_spec.rb on lines 28..36
spec/system/officing_spec.rb on lines 51..59
spec/system/officing_spec.rb on lines 62..70
spec/system/sdg_management_spec.rb on lines 19..27
spec/system/valuation_spec.rb on lines 17..25
spec/system/valuation_spec.rb on lines 28..36
spec/system/valuation_spec.rb on lines 39..47
spec/system/valuation_spec.rb on lines 50..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

  scenario "Access as an administrator is not authorized" do
    create(:administrator, user: user)
    login_as(user)

    visit officing_root_path
Severity: Major
Found in spec/system/officing_spec.rb and 16 other locations - About 20 mins to fix
spec/system/admin_spec.rb on lines 15..22
spec/system/admin_spec.rb on lines 25..32
spec/system/admin_spec.rb on lines 35..42
spec/system/admin_spec.rb on lines 45..52
spec/system/moderation_spec.rb on lines 16..24
spec/system/moderation_spec.rb on lines 27..35
spec/system/moderation_spec.rb on lines 38..46
spec/system/moderation_spec.rb on lines 49..57
spec/system/officing_spec.rb on lines 17..25
spec/system/officing_spec.rb on lines 28..36
spec/system/officing_spec.rb on lines 51..59
spec/system/sdg_management_spec.rb on lines 19..27
spec/system/valuation_spec.rb on lines 17..25
spec/system/valuation_spec.rb on lines 28..36
spec/system/valuation_spec.rb on lines 39..47
spec/system/valuation_spec.rb on lines 50..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 17 locations. Consider refactoring.
Open

  scenario "Access as a valuator is not authorized" do
    create(:valuator, user: user)
    login_as(user)

    visit officing_root_path
Severity: Major
Found in spec/system/officing_spec.rb and 16 other locations - About 20 mins to fix
spec/system/admin_spec.rb on lines 15..22
spec/system/admin_spec.rb on lines 25..32
spec/system/admin_spec.rb on lines 35..42
spec/system/admin_spec.rb on lines 45..52
spec/system/moderation_spec.rb on lines 16..24
spec/system/moderation_spec.rb on lines 27..35
spec/system/moderation_spec.rb on lines 38..46
spec/system/moderation_spec.rb on lines 49..57
spec/system/officing_spec.rb on lines 17..25
spec/system/officing_spec.rb on lines 28..36
spec/system/officing_spec.rb on lines 62..70
spec/system/sdg_management_spec.rb on lines 19..27
spec/system/valuation_spec.rb on lines 17..25
spec/system/valuation_spec.rb on lines 28..36
spec/system/valuation_spec.rb on lines 39..47
spec/system/valuation_spec.rb on lines 50..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 28.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status