AyuntamientoMadrid/participacion

File proposals_spec.rb has 1279 lines of code (exceeds 250 allowed). Consider refactoring.

Open

require "rails_helper"

describe "Proposals" do
  it_behaves_like "milestoneable", :proposal

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "Proposal index order filters" do
    scenario "Default order is hot_score" do
      best_proposal = create(:proposal, title: "Best proposal")
      best_proposal.update_column(:hot_score, 10)
      worst_proposal = create(:proposal, title: "Worst proposal")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe "Social share buttons" do
    context "On desktop browsers" do
      scenario "Shows links to share on facebook and twitter" do
        visit proposal_path(create(:proposal))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      scenario "Search by text" do
        proposal1 = create(:proposal, title: "Get Schwifty")
        proposal2 = create(:proposal, title: "Schwifty Hello")
        proposal3 = create(:proposal, title: "Do not show me")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    describe "Don't show suggestions" do
      let(:user) { create(:user) }
      let(:proposal) { create(:proposal, title: "Proposal title, has search term", author: user) }

      before do

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "Index view mode" do
      proposals = [create(:proposal), create(:proposal), create(:proposal)]

      visit proposals_path

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Update should not be posible if proposal is not editable" do
    Setting["max_votes_for_proposal_edit"] = 3
    proposal = create(:proposal, voters: Array.new(4) { create(:user) })

    expect(proposal).not_to be_editable

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "edit proposal with sdg related list" do
      proposal = create(:proposal, author: user)
      proposal.sdg_goals = [SDG::Goal[1], SDG::Goal[2]]
      login_as(user)
      visit edit_proposal_path(proposal)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#proposals") do
        expect(all(".proposal")[0].text).to match "Show you got"
        expect(all(".proposal")[1].text).to match "Show you got"
        expect(all(".proposal")[2].text).to match "Show what you got"
        expect(page).not_to have_content "Do not display"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Update should not be posible if logged user is not the author" do
    proposal = create(:proposal)
    expect(proposal).to be_editable
    login_as(create(:user))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      within("#proposals") do
        expect(all(".proposal")[0].text).to match "Show you got"
        expect(all(".proposal")[1].text).to match "Show what you got"
        expect(page).not_to have_content "Do not display with same tag"
        expect(page).not_to have_content "Do not display"

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      within("#proposals-list") do
        expect(all(".proposal")[0].text).to match "Most voted"
        expect(all(".proposal")[1].text).to match "Some votes"
        expect(all(".proposal")[2].text).to match "Least voted"

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

      within("#proposals") do
        expect(all(".proposal")[0].text).to match "Title content"
        expect(all(".proposal")[1].text).to match "Title here"
        expect(all(".proposal")[2].text).to match "In summary"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    scenario "When path does not match the friendly url" do
      proposal = create(:proposal)

      right_path = proposal_path(proposal)
      old_path = "#{proposals_path}/#{proposal.id}-something-else"

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Erased author" do
    user = create(:user)
    proposal = create(:proposal, author: user)
    user.erase

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

      proposals.each do |proposal|
        within("#proposals") do
          expect(page).to have_content proposal.title
          expect(page).to have_content proposal.summary
          expect(page).to have_link proposal.title, href: proposal_path(proposal)

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        within("#proposals") do
          expect(page).to have_css(".proposal", count: 2)
          expect(page).to have_content("Bigger sequoias")
          expect(page).to have_content("Green beach")
          expect(page).not_to have_content("Sully monument")

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

        within("#proposals") do
          expect(page).to have_css(".proposal", count: 2)
          expect(page).to have_content("Bigger sequoias")
          expect(page).to have_content("Green beach")
          expect(page).not_to have_content("Sully monument")

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Conflictive" do
    good_proposal = create(:proposal)
    conflictive_proposal = create(:proposal, :conflictive)

    visit proposal_path(conflictive_proposal)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  scenario "Errors on update" do
    proposal = create(:proposal)
    login_as(proposal.author)

    visit edit_proposal_path(proposal)

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  context "Concerns" do
    it_behaves_like "notifiable in-app", :proposal
    it_behaves_like "relationable", Proposal
    it_behaves_like "remotely_translatable", :proposal, "proposals_path", {}
    it_behaves_like "remotely_translatable", :proposal, "proposal_path", { id: "id" }

• Read up
  Read up