BAN-AI-Communications/k95-mingw

View on GitHub
k95source/ckuus3.c

Summary

Maintainability
Test Coverage

Showing 80 of 80 total issues

Either the condition s2?atof(s2):0.0 is redundant or there is possible null pointer dereference: s2.
Open

if (xxfloat(s2,0) == 2) {
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 3963..3963

Assignment of function parameter has no effect outside the function. Did you forget dereferencing it?
Open

px = NULL;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Either the condition if(diallac) is redundant or there is possible null pointer dereference: diallac.
Open

if (*diallac == '/')
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5516..5516

String literal compared with variable s. Did you intend to use strcmp() instead?
Open

if (s == "") s = NULL;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Either the condition if(diallcc) is redundant or there is possible null pointer dereference: diallcc.
Open

if (*diallcc == '+')
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5542..5542

Either the condition s is redundant or there is possible null pointer dereference: s.
Open

len = strlen(s);
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 10329..10329

String literal compared with variable s. Did you intend to use strcmp() instead?
Open

if (s == "") s = NULL;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Either the condition if(diallac) is redundant or there is possible null pointer dereference: diallac.
Open

if (*diallac == '(')
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5516..5516

BUG found
Open

static struct keytab tnbugtab[] = { /* TELNET BUG table */
Severity: Minor
Found in k95source/ckuus3.c by fixme

XXX found
Open

debug(F111,"XXX",p[1],x);
Severity: Minor
Found in k95source/ckuus3.c by fixme

BUG found
Open

case CK_TN_BUG: /* BUG */
Severity: Minor
Found in k95source/ckuus3.c by fixme

Too many #ifdef configurations - cppcheck only checks 12 of 570 configurations. Use --force to check all configurations.
Open

#endif /* NOICP */
Severity: Info
Found in k95source/ckuus3.c by cppcheck

Uninitialized variable: x
Open

if (x == -1) {
Severity: Critical
Found in k95source/ckuus3.c by cppcheck

Condition x is always true
Open

if (x && y != PROTO_K) {
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 6649..6649

Condition tncomport is always false
Open

if (tncomport) {
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 10698..10698

The scope of the variable c can be reduced.
Open

char c;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable c can be reduced.
Open

char c;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable c can be reduced.
Open

char c, buf1[32], buf2[32], * info[32], * p, * s;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable x can be reduced.
Open

int i, x = 0, z, ftp = 0, active = 0;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable x can be reduced.
Open

int x, n, mdm;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable i can be reduced.
Open

int i, x = 0, z, ftp = 0, active = 0;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable zz can be reduced.
Open

long zz;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable n shadows outer variable
Open

int n = 32;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 3447..3447

Unused variable: len
Open

int rc, len;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable dirsep can be reduced.
Open

char dirsep[2];
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable n can be reduced.
Open

int x, n, mdm;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable i shadows outer variable
Open

int i, xx;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 8672..8672

Local variable i shadows outer variable
Open

int i,len;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 8672..8672

The scope of the variable s can be reduced.
Open

char c, buf1[32], buf2[32], * info[32], * p, * s;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable jd can be reduced.
Open

long sec, jd;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Label xsetprn is not used.
Open

xsetprn: /* Common exit */
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable m shadows outer variable
Open

int m;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5811..5811

Local variable p shadows outer variable
Open

short *p;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 8674..8674

Clarify calculation precedence for & and ?.
Open

mdmspd = zz & CKD_SB ? 0 : 1; /* Set MODEM SPEED-MATCHING from it. */
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Unused variable: y
Open

int cx, x, y, z;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable autolocus shadows outer variable
Open

extern int locus, autolocus;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 1311..1311

Local variable tmpbuf shadows outer variable
Open

char *s, tmpbuf[XPCMDLEN+1];
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 327..327

Local variable zz shadows outer variable
Open

long zz;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 8673..8673

Unused variable: rc
Open

int i, rc;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable c can be reduced.
Open

char c, * s;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable getval can be reduced.
Open

int getval = 0; /* Whether to get switch value */
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Unused variable: x
Open

int cx, x, y, z;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Variable fpresult is reassigned a value before the old one has been used.
Open

fpresult = fpj;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 3960..3960

Variable x is reassigned a value before the old one has been used.
Open

x = 1;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5835..5835

Local variable zz shadows outer variable
Open

int zz;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 8673..8673

Local variable tmpbuf shadows outer variable
Open

char *s, tmpbuf[XPCMDLEN+1];
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 323..323

Variable x is reassigned a value before the old one has been used.
Open

x = 1;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5691..5691

Local variable p shadows outer variable
Open

char *p;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 8674..8674

Unused variable: rc
Open

int rc, len;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Variable text is assigned a value that is never used.
Open

char * text=NULL;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Clarify calculation precedence for & and ?.
Open

mdmspd = p->capas & CKD_SB ? 0 : 1; /* DIAL SPEED-MATCHING from it. */
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable x shadows outer variable
Open

int x;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5275..5275

Unused variable: y
Open

int cx, x, y, z;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Unused variable: z
Open

int cx, x, y, z;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Unused variable: rc
Open

int rc;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Variable x is assigned a value that is never used.
Open

int x = locus;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable y can be reduced.
Open

int y, z = 1;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable pflag shadows outer variable
Open

int pflag = 0; /* Have predicate */
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 134..134

Condition x is always false
Open

if (x && y != PROTO_K) {
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 6639..6639

Local variable line shadows outer variable
Open

char * line = NULL; /* For building macro argument list */
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 322..322

Unused variable: s
Open

char * s;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Variable s is reassigned a value before the old one has been used.
Open

s = line;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 12933..12933

Local variable k shadows outer variable
Open

int k;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 3447..3447

Local variable m shadows outer variable
Open

int m;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 5664..5664

The scope of the variable c can be reduced.
Open

char c, * p = tmpbuf;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The scope of the variable i can be reduced.
Open

int i, xx;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Unused variable: s
Open

char * s;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable line shadows outer variable
Open

char * line = NULL; /* For building macro argument list */
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 326..326

Local variable locus shadows outer variable
Open

extern int locus, autolocus;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 1311..1311

The scope of the variable getval can be reduced.
Open

int xmode = -1, fs = 0, getval = 0, simulate = 0, wild = 0;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable p shadows outer variable
Open

char *p = getenv("PATH");
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 8674..8674

Unused variable: x
Open

int cx, x, y, z;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Variable s2 is reassigned a value before the old one has been used.
Open

s2 = s; /* s2 is the result pointer */
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 3454..3454

Variable zz is reassigned a value before the old one has been used.
Open

zz = (long) x * 10L;
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 11143..11143

The scope of the variable zz can be reduced.
Open

int zz;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Local variable k shadows outer variable
Open

int k, ifcsav = ifc; /* save the IF state */
Severity: Minor
Found in k95source/ckuus3.c and 1 other location by cppcheck
k95source/ckuus3.c on lines 3447..3447

The scope of the variable c can be reduced.
Open

int c, n; /* Workers */
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

Unused variable: z
Open

int cx, x, y, z;
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The function shossh is never used.
Open

shossh() {
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

The function uq_mtxt is never used.
Open

uq_mtxt(preface,help,n,field)
Severity: Minor
Found in k95source/ckuus3.c by cppcheck

There are no issues that match your filters.

Category
Status