Sign upLogin

BBC-News/wraith

View on GitHub
Star
lib/wraith/save_images.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method capture_image_selenium has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def capture_image_selenium(screen_sizes, url, file_name, selector, global_before_capture, path_before_capture)
    driver = get_driver
    driver.manage.timeouts.implicit_wait = 10;
    screen_sizes.to_s.split(",").each do |screen_size|
      for attempt in 1..3 do
Severity: Minor
Found in lib/wraith/save_images.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method construct_command has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def construct_command(width, url, file_name, selector, global_before_capture, path_before_capture)
Severity: Minor
Found in lib/wraith/save_images.rb - About 45 mins to fix

    Method capture_image_selenium has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def capture_image_selenium(screen_sizes, url, file_name, selector, global_before_capture, path_before_capture)
    Severity: Minor
    Found in lib/wraith/save_images.rb - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status