Sign upLogin

BLSQ/orbf2

View on GitHub
Star
app/controllers/api/v2/zone_formulas_controller.rb

Summary

Maintainability
A
30 mins
Test Coverage
B
88%

Similar blocks of code found in 4 locations. Consider refactoring.
Open

  module V2
    class ZoneFormulasController < FormulasController
      def find_rule
        package = current_project_anchor.project.packages.find(params[:set_id])
        rule = package.zone_rule
Severity: Minor
Found in app/controllers/api/v2/zone_formulas_controller.rb and 3 other locations - About 30 mins to fix
app/controllers/api/v2/set_formulas_controller.rb on lines 4..12
app/controllers/api/v2/topic_formulas_controller.rb on lines 4..12
app/controllers/api/v2/zone_topic_formulas_controller.rb on lines 4..12

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 32.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Final newline missing.
Open

end
Severity: Minor
Found in app/controllers/api/v2/zone_formulas_controller.rb by rubocop

This cop looks for trailing blank lines and a final newline in the source code.

Example: EnforcedStyle: finalblankline

# `final_blank_line` looks for one blank line followed by a new line
# at the end of files.

# bad
class Foo; end
# EOF

# bad
class Foo; end # EOF

# good
class Foo; end

# EOF

Example: EnforcedStyle: final_newline (default)

# `final_newline` looks for one newline at the end of files.

# bad
class Foo; end

# EOF

# bad
class Foo; end # EOF

# good
class Foo; end
# EOF

Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
Open

        if rule.nil?
Severity: Minor
Found in app/controllers/api/v2/zone_formulas_controller.rb by rubocop

Checks for if and unless statements that would fit on one line if written as a modifier if/unless. The maximum line length is configured in the Metrics/LineLength cop. The tab size is configured in the IndentationWidth of the Layout/Tab cop.

Example:

# bad
if condition
  do_stuff(bar)
end

unless qux.empty?
  Foo.do_something
end

# good
do_stuff(bar) if condition
Foo.do_something unless qux.empty?

There are no issues that match your filters.

Category
Status