Sign upLogin

BLSQ/orbf2

View on GitHub
Star
app/controllers/setup/main_entity_groups_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
90%

Method has too many lines. [11/10]
Open

  def create
    unless current_project
      flash[:alert] = "Please configure your dhis2 settings first !"
      return redirect_to(root_path)
    end
Severity: Minor
Found in app/controllers/setup/main_entity_groups_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Line is too long. [125/100]
Open

      orgunitgroup = current_project.dhis2_connection.organisation_unit_groups.find(entity_group_params[:external_reference])
Severity: Minor
Found in app/controllers/setup/main_entity_groups_controller.rb by rubocop

Use nested module/class definitions instead of compact style.
Open

class Setup::MainEntityGroupsController < PrivateController
Severity: Minor
Found in app/controllers/setup/main_entity_groups_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

There are no issues that match your filters.

Category
Status