Sign upLogin

BLSQ/orbf2

View on GitHub
Star
app/controllers/setup/packages_controller.rb

Summary

Maintainability
A
25 mins
Test Coverage
C
78%

Method has too many lines. [23/10]
Open

  def create
    @package = current_project.packages.build(params_package)

    state_ids = params_package[:state_ids].reject(&:empty?)
Severity: Minor
Found in app/controllers/setup/packages_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [21/10]
Open

  def update
    @package = current_project.packages.find(params[:id])

    package.update(params_package)
Severity: Minor
Found in app/controllers/setup/packages_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def update
    @package = current_project.packages.find(params[:id])

    package.update(params_package)
Severity: Minor
Found in app/controllers/setup/packages_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Line is too long. [117/100]
Open

      flash[:failure] += "Please select at least one organisation group" unless params[:package][:main_entity_groups]
Severity: Minor
Found in app/controllers/setup/packages_controller.rb by rubocop

Use nested module/class definitions instead of compact style.
Open

class Setup::PackagesController < PrivateController
Severity: Minor
Found in app/controllers/setup/packages_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Line is too long. [109/100]
Open

      de_external_reference = params["data_elements"][package_state.state_id.to_s] if params["data_elements"]
Severity: Minor
Found in app/controllers/setup/packages_controller.rb by rubocop

There are no issues that match your filters.

Category
Status