Sign upLogin

BLSQ/orbf2

View on GitHub
Star
app/controllers/setup/projects_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage
B
87%

Method has too many lines. [14/10]
Open

  def create
    project_anchor = current_program.project_anchor || current_program.build_project_anchor
    unless current_program.project_anchor.projects.empty?
      raise "can't create a new one, need to update existing one"
    end
Severity: Minor
Found in app/controllers/setup/projects_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def project_params
    params.require(:project).permit(
      :name,
      :dhis2_url,
      :password,
Severity: Minor
Found in app/controllers/setup/projects_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Use nested module/class definitions instead of compact style.
Open

class Setup::ProjectsController < PrivateController
Severity: Minor
Found in app/controllers/setup/projects_controller.rb by rubocop

This cop checks the style of children definitions at classes and modules. Basically there are two different styles:

Example: EnforcedStyle: nested (default)

# good
# have each child on its own line
class Foo
  class Bar
  end
end

Example: EnforcedStyle: compact

# good
# combine definitions as much as possible
class Foo::Bar
end

The compact style is only forced for classes/modules with one child.

Missing magic comment # frozen_string_literal: true.
Open

class Setup::ProjectsController < PrivateController
Severity: Minor
Found in app/controllers/setup/projects_controller.rb by rubocop

This cop is designed to help upgrade to after Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default after Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: always (default)

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Useless assignment to variable - project_anchor. Did you mean project?
Open

    project_anchor = current_program.project_anchor || current_program.build_project_anchor
Severity: Minor
Found in app/controllers/setup/projects_controller.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

There are no issues that match your filters.

Category
Status