Sign upLogin

BLSQ/orbf2

View on GitHub
Star
app/workers/output_dataset_worker.rb

Summary

Maintainability
A
0 mins
Test Coverage
A
91%

Method has too many lines. [25/10]
Open

  def perform(project_id, payment_rule_code, frequency, options)
    modes = options.fetch("modes")
    @legacy_project = Project.find(project_id)

    Datasets::BuildDatasets.new(legacy_project).call
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Open

  def create_dataset(dataset, frequency)
    dataset_hash = Datasets::ToDhis2Datasets.new(dataset).call
    dataset_hash[:code] = @dataset_code
    dataset_hash[:name] = @dataset_name
    dataset_hash[:short_name] = @dataset_code
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Do not write to stdout. Use Rails's logger if you want to log.
Open

      puts "adding #{dse}"
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

This cop checks for the use of output calls like puts and print

Example:

# bad
puts 'A debug message'
pp 'A debug message'
print 'A debug message'

# good
Rails.logger.debug 'A debug message'

Unused method argument - frequency. If it's necessary, use _ or _frequency as an argument name to indicate that it won't be used.
Open

  def create_dataset(dataset, frequency)
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Do not use DateTime.now without zone. Use one of Time.zone.now, DateTime.current, DateTime.now.in_time_zone, DateTime.now.utc, DateTime.now.getlocal, DateTime.now.xmlschema, DateTime.now.iso8601, DateTime.now.jisx0301, DateTime.now.rfc3339, DateTime.now.httpdate, DateTime.now.to_i, DateTime.now.to_f instead.
Open

      dataset.update(last_synched_at: DateTime.now)
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

This cop checks for the use of Time methods without zone.

Built on top of Ruby on Rails style guide (https://github.com/rubocop-hq/rails-style-guide#time) and the article http://danilenko.org/2012/7/6/rails_timezones/

Two styles are supported for this cop. When EnforcedStyle is 'strict' then only use of Time.zone is allowed.

When EnforcedStyle is 'flexible' then it's also allowed to use Time.intimezone.

Example: EnforcedStyle: strict

# `strict` means that `Time` should be used with `zone`.

# bad
Time.now
Time.parse('2015-03-02 19:05:37')

# bad
Time.current
Time.at(timestamp).in_time_zone

# good
Time.zone.now
Time.zone.parse('2015-03-02 19:05:37')

Example: EnforcedStyle: flexible (default)

# `flexible` allows usage of `in_time_zone` instead of `zone`.

# bad
Time.now
Time.parse('2015-03-02 19:05:37')

# good
Time.zone.now
Time.zone.parse('2015-03-02 19:05:37')

# good
Time.current
Time.at(timestamp).in_time_zone

Line is too long. [108/100]
Open

    @dataset_name = "ORBF - " + @payment_rule.rule.name + " (#{@payment_rule.id}) - #{frequency.capitalize}"
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

Unused method argument - frequency. If it's necessary, use _ or _frequency as an argument name to indicate that it won't be used.
Open

  def load_dhis2_dataset(payment_rule, frequency, dataset)
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - payment_rule. If it's necessary, use _ or _payment_rule as an argument name to indicate that it won't be used.
Open

  def load_dhis2_dataset(payment_rule, frequency, dataset)
Severity: Minor
Found in app/workers/output_dataset_worker.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

There are no issues that match your filters.

Category
Status