BUTR/Bannerlord.BLSE

View on GitHub
src/Bannerlord.BLSE.Shared/ModuleInitializer.cs

Summary

Maintainability
D
2 days
Test Coverage

Method ResolveHarmonyAssembliesFile has 84 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private static string? ResolveHarmonyAssembliesFile(AssemblyName assemblyName)
    {
        var assemblyNameFull = $"{assemblyName.Name}.dll";
        var configName = Path.GetFileName(Directory.GetCurrentDirectory());

Severity: Major
Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 3 hrs to fix

    Method ResolveHarmonyAssembly has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static Assembly? ResolveHarmonyAssembly(AssemblyName assemblyName)
        {
            foreach (var assembly in AppDomain.CurrentDomain.GetAssemblies())
            {
                if (assembly.FullName == assemblyName.FullName)
    Severity: Minor
    Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 1 hr to fix

      Method ResolveLauncherExAssemblies has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private static Assembly? ResolveLauncherExAssemblies(AssemblyName assemblyName)
          {
              var @namespace = "Bannerlord.BLSE.Shared.";
              var resources = typeof(ModuleInitializer).Assembly.GetManifestResourceNames().Select(x => x.Remove(0, @namespace.Length));
              var versions = resources.Where(x => x.StartsWith("Bannerlord.LauncherEx_")).Select(x =>
      Severity: Minor
      Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 1 hr to fix

        Avoid too many return statements within this method.
        Open

                    return ResolveLauncherExAssemblies(assemblyName);
        Severity: Major
        Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return null;
          Severity: Major
          Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                            return assembly;
            Severity: Major
            Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return null;
              Severity: Major
              Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return null;
                Severity: Major
                Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return null;
                  Severity: Major
                  Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return Assembly.LoadFrom(assemblyFile);
                    Severity: Major
                    Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs - About 30 mins to fix

                      Identical blocks of code found in 4 locations. Consider refactoring.
                      Open

                      If the module was installed manually, try to do a clean reinstall!
                      If Vortex is used, try to reinstall manually!
                      If Steam is used, download the Harmony mod from NexusMods!
                      Don't forget that on Steam you have the '/Modules' folder in the Game
                      and the Steam Workshop folder that can conflict with each other!
                      Severity: Major
                      Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs and 3 other locations - About 2 hrs to fix
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 53..61
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 66..74
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 105..113

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 164.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 4 locations. Consider refactoring.
                      Open

                      If the module was installed manually, try to do a clean reinstall!
                      If Vortex is used, try to reinstall manually!
                      If Steam is used, download the Harmony mod from NexusMods!
                      Don't forget that on Steam you have the '/Modules' folder in the Game
                      and the Steam Workshop folder that can conflict with each other!
                      Severity: Major
                      Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs and 3 other locations - About 2 hrs to fix
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 53..61
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 66..74
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 92..100

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 164.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 4 locations. Consider refactoring.
                      Open

                      If the module was installed manually, try to do a clean reinstall!
                      If Vortex is used, try to reinstall manually!
                      If Steam is used, download the Harmony mod from NexusMods!
                      Don't forget that on Steam you have the '/Modules' folder in the Game
                      and the Steam Workshop folder that can conflict with each other!
                      Severity: Major
                      Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs and 3 other locations - About 2 hrs to fix
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 66..74
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 92..100
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 105..113

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 164.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      Identical blocks of code found in 4 locations. Consider refactoring.
                      Open

                      If the module was installed manually, try to do a clean reinstall!
                      If Vortex is used, try to reinstall manually!
                      If Steam is used, download the Harmony mod from NexusMods!
                      Don't forget that on Steam you have the '/Modules' folder in the Game
                      and the Steam Workshop folder that can conflict with each other!
                      Severity: Major
                      Found in src/Bannerlord.BLSE.Shared/ModuleInitializer.cs and 3 other locations - About 2 hrs to fix
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 53..61
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 92..100
                      src/Bannerlord.BLSE.Shared/ModuleInitializer.cs on lines 105..113

                      Duplicated Code

                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                      Tuning

                      This issue has a mass of 164.

                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                      Refactorings

                      Further Reading

                      There are no issues that match your filters.

                      Category
                      Status