BUTR/Bannerlord.BLSE

View on GitHub
src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs

Summary

Maintainability
D
1 day
Test Coverage

File LauncherVMMixin.cs has 446 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using Bannerlord.LauncherEx.Extensions;
using Bannerlord.LauncherEx.Helpers;
using Bannerlord.LauncherEx.ViewModels;
using Bannerlord.LauncherManager.Localization;
using Bannerlord.LauncherManager.Models;
Severity: Minor
Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs - About 6 hrs to fix

    Method ExecuteStartGameOverride has 38 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        [BUTRDataSourceMethod(OverrideName = "ExecuteStartGame")]
        public void ExecuteStartGameOverride(int mode)
        {
            if (ViewModel is null || ExecuteStartGame is null) return;
    
    
    Severity: Minor
    Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs - About 1 hr to fix

      Method ExecuteImport has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          [BUTRDataSourceMethod]
          public void ExecuteImport()
          {
              if (ViewModel is null || _launcherModsVMMixin is null || UpdateAndSaveUserModsDataMethod is null) return;
      
      
      Severity: Minor
      Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs - About 1 hr to fix

        Method SetState has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private void SetState()
            {
                if (ViewModel is null) return;
        
                OnPropertyChanged(nameof(IsSingleplayer2));
        Severity: Minor
        Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              [BUTRDataSourceProperty]
              public bool IsDigitalCompanion2
              {
                  get => _state == TopTabs.DigitalCompanion;
                  set
          Severity: Major
          Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs and 2 other locations - About 50 mins to fix
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 51..69
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 71..89

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              [BUTRDataSourceProperty]
              public bool IsMultiplayer2
              {
                  get => _state == TopTabs.Multiplayer;
                  set
          Severity: Major
          Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs and 2 other locations - About 50 mins to fix
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 51..69
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 106..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              [BUTRDataSourceProperty]
              public bool IsSingleplayer2
              {
                  get => _state == TopTabs.Singleplayer;
                  set
          Severity: Major
          Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs and 2 other locations - About 50 mins to fix
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 71..89
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 106..124

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              [BUTRDataSourceMethod]
              public void ExecuteBeginHintExport()
              {
                  if (IsSingleplayer2 && IsModsDataSelected)
                  {
          Severity: Minor
          Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs and 1 other location - About 35 mins to fix
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 391..402

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              [BUTRDataSourceMethod]
              public void ExecuteBeginHintImport()
              {
                  if (IsSingleplayer2 && IsModsDataSelected)
                  {
          Severity: Minor
          Found in src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs and 1 other location - About 35 mins to fix
          src/Bannerlord.LauncherEx/Mixins/LauncherVMMixin.cs on lines 404..415

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status