Sign upLogin

BUTR/Bannerlord.BLSE

View on GitHub
Star
src/Bannerlord.LauncherEx/ResourceManagers/SpriteDataManager.cs

Summary

Maintainability
B
5 hrs
Test Coverage

Method GetArrays has 49 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        protected override DrawObject2D GetArrays(SpriteDrawData spriteDrawData)
        {
            if (CachedDrawObject is not null && CachedDrawData == spriteDrawData)
                return CachedDrawObject;
Severity: Minor
Found in src/Bannerlord.LauncherEx/ResourceManagers/SpriteDataManager.cs - About 1 hr to fix

    Method PopulateVertices has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            private static void PopulateVertices(Texture texture, float screenX, float screenY, float[] outVertices, int verticesStartIndex, float scale, float customWidth, float customHeight)
    Severity: Major
    Found in src/Bannerlord.LauncherEx/ResourceManagers/SpriteDataManager.cs - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                  if (FieldMapX is null || FieldMapY is null || FieldWidth is null || FieldHeight is null || FieldHorizontalFlip is null || FieldVerticalFlip is null)
                return null!;
      Severity: Major
      Found in src/Bannerlord.LauncherEx/ResourceManagers/SpriteDataManager.cs - About 40 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

            internal static bool Enable(Harmony harmony)
    {
        var res1 = harmony.TryPatch(
            AccessTools2.Method(typeof(SpriteData), "GetSprite"),
            prefix: AccessTools2.DeclaredMethod(typeof(SpriteDataManager), nameof(GetSpritePrefix)));
        Severity: Major
        Found in src/Bannerlord.LauncherEx/ResourceManagers/SpriteDataManager.cs and 2 other locations - About 2 hrs to fix
        src/Bannerlord.LauncherEx/Patches/UserDataManagerPatch.cs on lines 21..34
        src/Bannerlord.LauncherEx/ResourceManagers/GraphicsContextManager.cs on lines 53..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 155.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status