Sign upLogin

Badgerati/Edison

View on GitHub
Star
Edison.Engine/Repositories/AssemblyRepository.cs

Summary

Maintainability
B
6 hrs
Test Coverage

Method GetTestCount has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public int GetTestCount(
            Assembly assembly,
            IList<string> includedCategories,
            IList<string> excludedCategories,
            IList<string> fixtures,
Severity: Minor
Found in Edison.Engine/Repositories/AssemblyRepository.cs - About 1 hr to fix

    Method GetCategories has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public IEnumerable<string> GetCategories(
            Assembly assembly,
            IEnumerable<MethodInfo> tests = default(IEnumerable<MethodInfo>),
            IEnumerable<Type> fixtures = default(IEnumerable<Type>))
        {
    Severity: Minor
    Found in Edison.Engine/Repositories/AssemblyRepository.cs - About 1 hr to fix

      Method GetTestFixtures has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  Assembly assembly,
            IList<string> includedCategories,
            IList<string> excludedCategories,
            IList<string> fixtures,
            IList<string> tests,
      Severity: Minor
      Found in Edison.Engine/Repositories/AssemblyRepository.cs - About 45 mins to fix

        Method GetTestCount has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    Assembly assembly,
            IList<string> includedCategories,
            IList<string> excludedCategories,
            IList<string> fixtures,
            IList<string> tests,
        Severity: Minor
        Found in Edison.Engine/Repositories/AssemblyRepository.cs - About 45 mins to fix

          Method GetTests has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                      Assembly assembly,
            IList<string> includedCategories,
            IList<string> excludedCategories,
            IList<string> fixtures,
            IList<string> tests,
          Severity: Minor
          Found in Edison.Engine/Repositories/AssemblyRepository.cs - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        var testCategories = tests
                .Select(x => ReflectionRepository.GetCategories(x))
                .Aggregate((a, b) => b.Concat(a))
                .Distinct();
            Severity: Minor
            Found in Edison.Engine/Repositories/AssemblyRepository.cs and 1 other location - About 35 mins to fix
            Edison.Engine/Repositories/AssemblyRepository.cs on lines 145..148

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        var fixtureCategories = fixtures
                .Select(x => ReflectionRepository.GetCategories(x))
                .Aggregate((a, b) => b.Concat(a))
                .Distinct();
            Severity: Minor
            Found in Edison.Engine/Repositories/AssemblyRepository.cs and 1 other location - About 35 mins to fix
            Edison.Engine/Repositories/AssemblyRepository.cs on lines 150..153

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 65.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status