Badgerati/Edison

View on GitHub

Showing 215 of 215 total issues

Avoid too many return statements within this method.
Open

                return false;
Severity: Major
Found in Edison.Engine/Repositories/ReflectionRepository.cs - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return true;
    Severity: Major
    Found in Edison.Console/ParameterParser.cs - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return fixtureCategories.Any() && HasValidCategories(fixture, includedCategories, excludedCategories, false);
      Severity: Major
      Found in Edison.Engine/Repositories/ReflectionRepository.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return true;
        Severity: Major
        Found in Edison.Engine/Repositories/ReflectionRepository.cs - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          tests = tests.Where(t => ReflectionRepository.HasValidConcurrency(t, ConcurrencyType.Parallel, ConcurrencyType)).OrderBy(t => t.Name).ToList();
          Severity: Minor
          Found in Edison.Engine/Threading/TestFixtureThread.cs and 1 other location - About 30 mins to fix
          Edison.Engine/Threading/TestFixtureThread.cs on lines 225..225

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (context.Assemblies.Contains(dll1Win))
                      {
                          Assert.Contains(dll1Win, context.Assemblies);
                      }
                      else
          Severity: Minor
          Found in Edison.Engine.Test/Contexts/ContextValidatorTests.cs and 1 other location - About 30 mins to fix
          Edison.Engine.Test/Contexts/ContextValidatorTests.cs on lines 194..201

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (context.Assemblies.Contains(dllWin))
                      {
                          Assert.Contains(dllWin, context.Assemblies);
                      }
                      else
          Severity: Minor
          Found in Edison.Engine.Test/Contexts/ContextValidatorTests.cs and 1 other location - About 30 mins to fix
          Edison.Engine.Test/Contexts/ContextValidatorTests.cs on lines 244..251

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          singularTests = tests.Where(t => ReflectionRepository.HasValidConcurrency(t, ConcurrencyType.Serial, ConcurrencyType)).OrderBy(t => t.Name).ToList();
          Severity: Minor
          Found in Edison.Engine/Threading/TestFixtureThread.cs and 1 other location - About 30 mins to fix
          Edison.Engine/Threading/TestFixtureThread.cs on lines 226..226

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 60.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Multiple top level headers in the same document
          Open

          # Usage
          Severity: Info
          Found in README.md by markdownlint

          MD025 - Multiple top level headers in the same document

          Tags: headers

          Aliases: single-h1

          Parameters: level (number; default 1)

          This rule is triggered when a top level header is in use (the first line of the file is a h1 header), and more than one h1 header is in use in the document:

          # Top level header
          
          # Another top level header

          To fix, structure your document so that there is a single h1 header that is the title for the document, and all later headers are h2 or lower level headers:

          # Title
          
          ## Header
          
          ## Another header

          Rationale: A top level header is a h1 on the first line of the file, and serves as the title for the document. If this convention is in use, then there can not be more than one title for the document, and the entire document should be contained within this header.

          Note: The level parameter can be used to change the top level (ex: to h2) in cases where an h1 is added externally.

          Multiple top level headers in the same document
          Open

          # Features
          Severity: Info
          Found in README.md by markdownlint

          MD025 - Multiple top level headers in the same document

          Tags: headers

          Aliases: single-h1

          Parameters: level (number; default 1)

          This rule is triggered when a top level header is in use (the first line of the file is a h1 header), and more than one h1 header is in use in the document:

          # Top level header
          
          # Another top level header

          To fix, structure your document so that there is a single h1 header that is the title for the document, and all later headers are h2 or lower level headers:

          # Title
          
          ## Header
          
          ## Another header

          Rationale: A top level header is a h1 on the first line of the file, and serves as the title for the document. If this convention is in use, then there can not be more than one title for the document, and the entire document should be contained within this header.

          Note: The level parameter can be used to change the top level (ex: to h2) in cases where an h1 is added externally.

          Lists should be surrounded by blank lines
          Open

          * A `TestFixture` which contains multiple `Test`s to be run
          Severity: Info
          Found in README.md by markdownlint

          MD032 - Lists should be surrounded by blank lines

          Tags: bullet, ul, ol, blank_lines

          Aliases: blanks-around-lists

          This rule is triggered when lists (of any kind) are either not preceded or not followed by a blank line:

          Some text
          * Some
          * List
          
          1. Some
          2. List
          Some text

          To fix this, ensure that all lists have a blank line both before and after (except where the block is at the beginning or end of the document):

          Some text
          
          * Some
          * List
          
          1. Some
          2. List
          
          Some text

          Rationale: Aside from aesthetic reasons, some parsers, including kramdown, will not parse lists that don't have blank lines before and after them.

          Note: List items without hanging indents are a violation of this rule; list items with hanging indents are okay:

          * This is
          not okay
          
          * This is
            okay

          Multiple top level headers in the same document
          Open

          # Installing Edison
          Severity: Info
          Found in README.md by markdownlint

          MD025 - Multiple top level headers in the same document

          Tags: headers

          Aliases: single-h1

          Parameters: level (number; default 1)

          This rule is triggered when a top level header is in use (the first line of the file is a h1 header), and more than one h1 header is in use in the document:

          # Top level header
          
          # Another top level header

          To fix, structure your document so that there is a single h1 header that is the title for the document, and all later headers are h2 or lower level headers:

          # Title
          
          ## Header
          
          ## Another header

          Rationale: A top level header is a h1 on the first line of the file, and serves as the title for the document. If this convention is in use, then there can not be more than one title for the document, and the entire document should be contained within this header.

          Note: The level parameter can be used to change the top level (ex: to h2) in cases where an h1 is added externally.

          Headers should be surrounded by blank lines
          Open

          # Usage
          Severity: Info
          Found in README.md by markdownlint

          MD022 - Headers should be surrounded by blank lines

          Tags: headers, blank_lines

          Aliases: blanks-around-headers

          This rule is triggered when headers (any style) are either not preceded or not followed by a blank line:

          # Header 1
          Some text
          
          Some more text
          ## Header 2

          To fix this, ensure that all headers have a blank line both before and after (except where the header is at the beginning or end of the document):

          # Header 1
          
          Some text
          
          Some more text
          
          ## Header 2

          Rationale: Aside from aesthetic reasons, some parsers, including kramdown, will not parse headers that don't have a blank line before, and will parse them as regular text.

          Multiple top level headers in the same document
          Open

          # Bugs and Feature Requests
          Severity: Info
          Found in README.md by markdownlint

          MD025 - Multiple top level headers in the same document

          Tags: headers

          Aliases: single-h1

          Parameters: level (number; default 1)

          This rule is triggered when a top level header is in use (the first line of the file is a h1 header), and more than one h1 header is in use in the document:

          # Top level header
          
          # Another top level header

          To fix, structure your document so that there is a single h1 header that is the title for the document, and all later headers are h2 or lower level headers:

          # Title
          
          ## Header
          
          ## Another header

          Rationale: A top level header is a h1 on the first line of the file, and serves as the title for the document. If this convention is in use, then there can not be more than one title for the document, and the entire document should be contained within this header.

          Note: The level parameter can be used to change the top level (ex: to h2) in cases where an h1 is added externally.

          Multiple top level headers in the same document
          Open

          # License
          Severity: Info
          Found in README.md by markdownlint

          MD025 - Multiple top level headers in the same document

          Tags: headers

          Aliases: single-h1

          Parameters: level (number; default 1)

          This rule is triggered when a top level header is in use (the first line of the file is a h1 header), and more than one h1 header is in use in the document:

          # Top level header
          
          # Another top level header

          To fix, structure your document so that there is a single h1 header that is the title for the document, and all later headers are h2 or lower level headers:

          # Title
          
          ## Header
          
          ## Another header

          Rationale: A top level header is a h1 on the first line of the file, and serves as the title for the document. If this convention is in use, then there can not be more than one title for the document, and the entire document should be contained within this header.

          Note: The level parameter can be used to change the top level (ex: to h2) in cases where an h1 is added externally.

          Severity
          Category
          Status
          Source
          Language