Sign upLogin

Badgerati/Icarus

View on GitHub
Star
Icarus.Core/IcarusCollection.cs

Summary

Maintainability
D
2 days
Test Coverage

File IcarusCollection.cs has 580 lines of code (exceeds 250 allowed). Consider refactoring.
Open

using Newtonsoft.Json;
using Newtonsoft.Json.Linq;
using System;
using System.Linq;
using System.Collections.Generic;
Severity: Major
Found in Icarus.Core/IcarusCollection.cs - About 1 day to fix

    Class IcarusCollection has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

        public class IcarusCollection<T> : IIcarusCollection<T> where T : IIcarusObject
    {

        #region Constants
    Severity: Minor
    Found in Icarus.Core/IcarusCollection.cs - About 3 hrs to fix

      Method Update has 61 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public T Update(T item, bool persist = true)
        {
            if (Equals(item, default(T)))
            {
                throw new IcarusException("Cannot update an object with null.");
      Severity: Major
      Found in Icarus.Core/IcarusCollection.cs - About 2 hrs to fix

        Method LoadJsonData has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private void LoadJsonData()
        {
            try
            {
                // try decrypting or just reading the data first
        Severity: Minor
        Found in Icarus.Core/IcarusCollection.cs - About 1 hr to fix

          Method Insert has 42 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public T Insert(T item, bool persist = true)
        {
            if (Equals(item, default(T)))
            {
                throw new IcarusException("Cannot insert null item.");
          Severity: Minor
          Found in Icarus.Core/IcarusCollection.cs - About 1 hr to fix

            Method Remove has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public T Remove(long id, bool persist = true)
        {
            var _item = default(JToken);
            var _castItem = default(T);
            var _error = false;
            Severity: Minor
            Found in Icarus.Core/IcarusCollection.cs - About 1 hr to fix

              Method Update has a Cognitive Complexity of 25 (exceeds 20 allowed). Consider refactoring.
              Open

                      public T Update(T item, bool persist = true)
        {
            if (Equals(item, default(T)))
            {
                throw new IcarusException("Cannot update an object with null.");
              Severity: Minor
              Found in Icarus.Core/IcarusCollection.cs - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                      {
                            var hash = reader.ReadToEnd();
                            var data = _encryptionModule.Decrypt(hash);

                            using (var sReader = new StringReader(data))
              Severity: Minor
              Found in Icarus.Core/IcarusCollection.cs and 1 other location - About 55 mins to fix
              Icarus.Core/IcarusCollection.cs on lines 813..821

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 83.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                                  {
                        var hash = reader.ReadToEnd();
                        var data = _encryptionModule.Decrypt(hash);

                        using (var sReader = new StringReader(data))
              Severity: Minor
              Found in Icarus.Core/IcarusCollection.cs and 1 other location - About 55 mins to fix
              Icarus.Core/IcarusCollection.cs on lines 841..849

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 83.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status