Sign upLogin

Badgerati/NotifyMeCI

View on GitHub
Star
NotifyMeCI.GUI/Validator.cs

Summary

Maintainability
B
5 hrs
Test Coverage

Method ValidateServerValues has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        public static string ValidateServerValues(string serverType, string name, string url, int poll, string apiToken, bool uniqueName = true)
        {
            try
            {
                // check server type
Severity: Minor
Found in NotifyMeCI.GUI/Validator.cs - About 2 hrs to fix

    Method ValidateServerValues has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            public static string ValidateServerValues(string serverType, string name, string url, int poll, string apiToken, bool uniqueName = true)
    Severity: Minor
    Found in NotifyMeCI.GUI/Validator.cs - About 45 mins to fix

      Method ValidateServerValues has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

              public static string ValidateServerValues(string serverType, string name, string url, int poll, string apiToken, bool uniqueName = true)
        {
            try
            {
                // check server type
      Severity: Minor
      Found in NotifyMeCI.GUI/Validator.cs - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                          return string.Format("Invalid Server URL when adding new server: '{0}'", url);
      Severity: Major
      Found in NotifyMeCI.GUI/Validator.cs - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                            return error;
        Severity: Major
        Found in NotifyMeCI.GUI/Validator.cs - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return string.Format("There was a fatal issue when validating the server information:{0}{0}{1}", Environment.NewLine, ex.Message);
          Severity: Major
          Found in NotifyMeCI.GUI/Validator.cs - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return string.Empty;
            Severity: Major
            Found in NotifyMeCI.GUI/Validator.cs - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                          return string.Format("Invalid API Token supplied: '{0}'", apiToken);
              Severity: Major
              Found in NotifyMeCI.GUI/Validator.cs - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status