Function save
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function save()
{
if ($this->read_only) {
throw new \RuntimeException('This config store is read only.');
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method save
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function save()
{
if ($this->read_only) {
throw new \RuntimeException('This config store is read only.');
}
The method save() has an NPath complexity of 640. The configured NPath complexity threshold is 200. Open
public function save()
{
if ($this->read_only) {
throw new \RuntimeException('This config store is read only.');
}
- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}
Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method save() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10. Open
public function save()
{
if ($this->read_only) {
throw new \RuntimeException('This config store is read only.');
}
- Read upRead up
- Exclude checks
CyclomaticComplexity
Since: 0.1
Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.
Example
// Cyclomatic Complexity = 11
class Foo {
1 public function example() {
2 if ($a == $b) {
3 if ($a1 == $b1) {
fiddle();
4 } elseif ($a2 == $b2) {
fiddle();
} else {
fiddle();
}
5 } elseif ($c == $d) {
6 while ($c == $d) {
fiddle();
}
7 } elseif ($e == $f) {
8 for ($n = 0; $n < $h; $n++) {
fiddle();
}
} else {
switch ($z) {
9 case 1:
fiddle();
break;
10 case 2:
fiddle();
break;
11 case 3:
fiddle();
break;
default:
fiddle();
break;
}
}
}
}
Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity
Missing class import via use statement (line '237', column '23'). Open
throw new \RuntimeException('This config store is read only.');
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
rewind($fp);
fwrite($fp, implode("\n", $lines) . "\n");
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
The method save uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$fp = $this->file_path;
rewind($fp);
}
- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}
Source https://phpmd.org/rules/cleancode.html#elseexpression
Call to undeclared method \Baguette\Mastodon\Config\DotEnvStorage::readLinesFromFile
Open
return $this->readLinesFromFile($fp);
- Exclude checks
Class extends undeclared class \Dotenv\Loader
Open
class DotEnvStorage extends \Dotenv\Loader implements Storage
- Exclude checks
Class uses undeclared trait \Teto\Object\ReadOnly
Open
class DotEnvStorage extends \Dotenv\Loader implements Storage
- Exclude checks
Call to method contains
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($client_secret);
- Exclude checks
Call to method stringType
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($access_token);
- Exclude checks
Call to undeclared method \Baguette\Mastodon\Config\DotEnvStorage::isComment
Open
if (!$this->isComment($line) && $this->looksLikeSetter($line)) {
- Exclude checks
Call to method stringType
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($app_name);
- Exclude checks
Call to method contains
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($password);
- Exclude checks
Call to undeclared method \Baguette\Mastodon\Config\DotEnvStorage::normaliseEnvironmentVariable
Open
list($key, $val) = $this->normaliseEnvironmentVariable($line, '');
- Exclude checks
@throws type of __construct
has undeclared type \Dotenv\Exception\InvalidPathException
Open
public function __construct($file_path, $options = [])
- Exclude checks
Call to method contains
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($access_token);
- Exclude checks
Call to undeclared method \Baguette\Mastodon\Config\DotEnvStorage::looksLikeSetter
Open
if (!$this->isComment($line) && $this->looksLikeSetter($line)) {
- Exclude checks
Call to undeclared method \Baguette\Mastodon\Config\DotEnvStorage::isComment
Open
if ($this->isComment($line) || !$this->looksLikeSetter($line)) {
- Exclude checks
Call to method boolType
from undeclared class \Respect\Validation\Validator
Open
v::boolType()->assert($options['read_only']);
- Exclude checks
Call to method stringType
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($client_secret);
- Exclude checks
Call to method contains
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($client_id);
- Exclude checks
Call to method contains
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($username);
- Exclude checks
Call to method stringType
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($username);
- Exclude checks
Call to method stringType
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($password);
- Exclude checks
Call to undeclared method \Baguette\Mastodon\Config\DotEnvStorage::looksLikeSetter
Open
if ($this->isComment($line) || !$this->looksLikeSetter($line)) {
- Exclude checks
Call to method contains
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($app_name);
- Exclude checks
Saw unextractable annotation for comment '* @Return array'
Open
* @Return array
- Exclude checks
Call to undeclared method \Baguette\Mastodon\Config\DotEnvStorage::normaliseEnvironmentVariable
Open
list($key, $val) = $this->normaliseEnvironmentVariable($line, '');
- Exclude checks
Reference to undeclared class \Dotenv\Loader
Open
parent::__construct($file_path);
- Exclude checks
Call to method intType
from undeclared class \Respect\Validation\Validator
Open
v::intType()->min(0)->assert($created_at);
- Exclude checks
Call to method stringType
from undeclared class \Respect\Validation\Validator
Open
v::stringType()->not(v::contains("\n"))->assert($client_id);
- Exclude checks
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function getClientIdAndSecret()
{
$id_key = $this->key_names['client_id'];
$sec_key = $this->key_names['client_secret'];
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function getUsernameAndPassword()
{
$user_key = $this->key_names['username'];
$pass_key = $this->key_names['password'];
$values = $this->getValues();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 92.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function setClientIdAndSecret($client_id, $client_secret)
{
v::stringType()->not(v::contains("\n"))->assert($client_id);
v::stringType()->not(v::contains("\n"))->assert($client_secret);
$this->save_values['client_id'] = $client_id;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 90.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function setUsernameAndPassword($username, $password)
{
v::stringType()->not(v::contains("\n"))->assert($username);
v::stringType()->not(v::contains("\n"))->assert($password);
$this->save_values['username'] = $username;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 90.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76