BaguettePHP/mastodon-api

View on GitHub
src/Requester.php

Summary

Maintainability
D
2 days
Test Coverage

Call to method stringType from undeclared class \Respect\Validation\Validator
Open

            v::stringType()->assert($update_data['note']);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['max_id']);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['since_id']);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['limit']);
Severity: Critical
Found in src/Requester.php by phan

Call to method getBody from undeclared class \Psr\Http\Message\ResponseInterface
Open

            \GuzzleHttp\json_decode($response->getBody(), true)
Severity: Critical
Found in src/Requester.php by phan

Return type of getFollowRequests() is undeclared type \Baguette\Mastodon\Entity\accounts[] (Did you mean class \Baguette\Mastodon\Entity\Account)
Open

    public static function getFollowRequests(Client $client, SessionStorage $session, $options = [])
Severity: Minor
Found in src/Requester.php by phan

Call to method stringType from undeclared class \Respect\Validation\Validator
Open

            v::stringType()->assert($update_data['display_name']);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['limit']);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

        v::intVal()->assert($status_id);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['max_id']);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

        v::intVal()->min(0)->assert($id);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['max_id']);
Severity: Critical
Found in src/Requester.php by phan

Returning type \Baguette\Mastodon\Entity\Entity|\Baguette\Mastodon\Entity\Entity[] but getFollowRequests() is declared to return \Baguette\Mastodon\Entity\accounts[]
Open

        return static::map(
Severity: Minor
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

        v::intVal()->assert($account_id);
Severity: Critical
Found in src/Requester.php by phan

Parameter $response has undeclared type \Psr\Http\Message\ResponseInterface
Open

    private static function map($class, ResponseInterface $response)
Severity: Minor
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['limit']);
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['since_id']);
Severity: Critical
Found in src/Requester.php by phan

Call to undeclared function \GuzzleHttp\json_decode() (Did you mean \json_decode() or \json_encode())
Open

            \GuzzleHttp\json_decode($response->getBody(), true)
Severity: Critical
Found in src/Requester.php by phan

Call to method intVal from undeclared class \Respect\Validation\Validator
Open

            v::intVal()->min(0)->assert($options['since_id']);
Severity: Critical
Found in src/Requester.php by phan

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function getFollowRequests(Client $client, SessionStorage $session, $options = [])
    {
        $query = [];

        if (isset($options['max_id'])) {
Severity: Major
Found in src/Requester.php and 2 other locations - About 6 hrs to fix
src/Requester.php on lines 124..149
src/Requester.php on lines 160..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 221.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function getFavourites(Client $client, SessionStorage $session, $options = [])
    {
        $query = [];

        if (isset($options['max_id'])) {
Severity: Major
Found in src/Requester.php and 2 other locations - About 6 hrs to fix
src/Requester.php on lines 124..149
src/Requester.php on lines 196..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 221.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public static function getBlocks(Client $client, SessionStorage $session, $options = [])
    {
        $query = [];

        if (isset($options['max_id'])) {
Severity: Major
Found in src/Requester.php and 2 other locations - About 6 hrs to fix
src/Requester.php on lines 160..185
src/Requester.php on lines 196..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 221.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status