BallAerospace/COSMOS

View on GitHub
cosmos/lib/cosmos/core_ext/array.rb

Summary

Maintainability
F
3 days
Test Coverage

Method histogram has a Cognitive Complexity of 71 (exceeds 5 allowed). Consider refactoring.
Open

  def histogram(num_buckets = nil, numeric = false, &block)
    buckets = {}

    # Count the occurance of each value
    self.each do |value|
Severity: Minor
Found in cosmos/lib/cosmos/core_ext/array.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method nearest_index has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

  def nearest_index(value, ordered_data = true)
    raise "Cannot search on empty array" if self.empty?

    if ordered_data
      last_index  = self.length - 1
Severity: Minor
Found in cosmos/lib/cosmos/core_ext/array.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

            if guess_value > value # Moving with decreasing indexes
              if previous_guess_value > value # Still moving in right direction
                previous_guess_index = guess_index
                guess_index -= 1
              else # We passed the value
Severity: Major
Found in cosmos/lib/cosmos/core_ext/array.rb - About 45 mins to fix

    Avoid too many return statements within this method.
    Open

          return closest_index
    Severity: Major
    Found in cosmos/lib/cosmos/core_ext/array.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return guess_index
      Severity: Major
      Found in cosmos/lib/cosmos/core_ext/array.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return last_index
        Severity: Major
        Found in cosmos/lib/cosmos/core_ext/array.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return 0 if guess_index < 0
          Severity: Major
          Found in cosmos/lib/cosmos/core_ext/array.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return previous_guess_index
            Severity: Major
            Found in cosmos/lib/cosmos/core_ext/array.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                              return guess_index
              Severity: Major
              Found in cosmos/lib/cosmos/core_ext/array.rb - About 30 mins to fix

                Method min_with_index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def min_with_index
                      minimum = nil
                      minimum_index = nil
                
                      if self.length > 0
                Severity: Minor
                Found in cosmos/lib/cosmos/core_ext/array.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method max_with_index has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    def max_with_index
                      maximum = nil
                      maximum_index = nil
                
                      if self.length > 0
                Severity: Minor
                Found in cosmos/lib/cosmos/core_ext/array.rb - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def max_with_index
                      maximum = nil
                      maximum_index = nil
                
                      if self.length > 0
                Severity: Minor
                Found in cosmos/lib/cosmos/core_ext/array.rb and 1 other location - About 55 mins to fix
                cosmos/lib/cosmos/core_ext/array.rb on lines 273..291

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    def min_with_index
                      minimum = nil
                      minimum_index = nil
                
                      if self.length > 0
                Severity: Minor
                Found in cosmos/lib/cosmos/core_ext/array.rb and 1 other location - About 55 mins to fix
                cosmos/lib/cosmos/core_ext/array.rb on lines 251..269

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 45.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status