Banda-Media/lunchMemo

View on GitHub

Showing 5 of 5 total issues

Function Login has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const Login: React.FC = () => {
  const { login, loginProvider } = useAuth();
  const form = useForm(formDefaults);
  const { notify } = useNotify();
  const router = useRouter();
Severity: Minor
Found in app/components/modules/registration/Login.tsx - About 1 hr to fix

    Function CreateGroup has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const CreateGroup: React.FC = () => {
      const form = useForm(formDefaults);
      const { addGroup } = useLunchGroup();
      const { notify } = useNotify();
      const { user } = useAuth();
    Severity: Minor
    Found in app/components/modules/dashboard/components/CreateGroup.tsx - About 1 hr to fix

      Function RegistrationPanel has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const RegistrationPanel: React.FC = () => {
        const [route, setRoute] = useState('');
        useEffect(() => {
          const pathName = window && window.location.pathname;
          setRoute(pathName);
      Severity: Minor
      Found in app/components/modules/registration/RegistrationPanel.tsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const getUser = async (id: string): Promise<User> => {
          return await getDoc<User>(USER_COLLECTION, id);
        };
        Severity: Minor
        Found in app/services/firebase/firestore.ts and 1 other location - About 40 mins to fix
        app/services/firebase/firestore.ts on lines 59..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const getGroup = async (id: string): Promise<ILunchGroup> => {
          return await getDoc<ILunchGroup>(GROUPS_COLLECTION, id);
        };
        Severity: Minor
        Found in app/services/firebase/firestore.ts and 1 other location - About 40 mins to fix
        app/services/firebase/firestore.ts on lines 55..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language