Showing 166 of 304 total issues
Method analysis_date
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.analysis_date(meter_collection, fuel_type)
return Time.zone.today unless fuel_type
fuel_type = fuel_type.to_sym
if fuel_type == :gas
meter_collection.aggregated_heat_meters.amr_data.end_date
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method percent_change
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def self.percent_change(base, new_val, to_nil_if_sum_zero = false)
return nil if to_nil_if_sum_zero && sum_data(base) == 0.0
return 0.0 if sum_data(base) == 0.0
change = (sum_data(new_val) - sum_data(base)) / sum_data(base)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def initialize(school_group_ids: [], scoreboard_ids: [], school_types: [], school_type: nil, country: nil, funder: nil, include_invisible: false)
@school_group_ids = school_group_ids.reject(&:blank?)
@scoreboard_ids = scoreboard_ids.reject(&:blank?)
@school_types = school_type.present? ? [school_type] : school_types
@funders = funder.present? ? [funder] : []
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_progress_report_fuel_type
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def add_progress_report_fuel_type(row, fuel_target, fuel_progress)
if fuel_target.present?
row += [
format_percent_reduction(fuel_target),
fuel_progress.present? && fuel_progress.progress.present? ? format_target(fuel_progress.progress) : nil
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method check_response_status
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def check_response_status(response)
raise BadRequest.new(error_message(response)) if response.status == 400
raise NotAuthorised.new(error_message(response)) if response.status == 401
raise NotAllowed.new(error_message(response)) if response.status == 403
raise NotFound.new(error_message(response)) if response.status == 404
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method tags
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def tags
ret = []
if @school.percentage_free_school_meals
percent = @school.percentage_free_school_meals
if percent >= 30
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"