Sign upLogin

BathHacked/energy-sparks

View on GitHub
Star

Showing 268 of 276 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        mouseOnDay: function(e) {
          if(e.events.length > 0) {
            var content = '';
            for(var i in e.events) {
              var startDate = e.events[i].startDate;
Severity: Major
Found in app/assets/javascripts/calendar_year_view.js and 1 other location - About 1 day to fix
app/assets/javascripts/calendar_year_view.js on lines 98..119

Identical blocks of code found in 2 locations. Consider refactoring.
Open

        mouseOnDay: function(e) {
          if(e.events.length > 0) {
            var content = '';
            for(var i in e.events) {
              var startDate = e.events[i].startDate;
Severity: Major
Found in app/assets/javascripts/calendar_year_view.js and 1 other location - About 1 day to fix
app/assets/javascripts/calendar_year_view.js on lines 152..173

File application_helper.rb has 471 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module ApplicationHelper
  include Pagy::Frontend
 
  def nice_date_times(datetime, options = {})
    return '' if datetime.nil?
Severity: Minor
Found in app/helpers/application_helper.rb - About 7 hrs to fix

    Class ChartDataValues has 51 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class ChartDataValues
      attr_reader :anaylsis_type, :title, :subtitle, :chart1_type, :chart1_subtype,
                  :y_axis_label, :x_axis_label, :x_axis_categories, :x_max_value, :x_min_value,
                  :advice_header, :advice_footer, :y2_axis_label, :y2_point_format, :y2_max, :x_axis_ranges, :annotations,
                  :transformations, :allowed_operations, :drilldown_available, :parent_timescale_description,
    Severity: Major
    Found in app/models/chart_data_values.rb - About 7 hrs to fix

      Method initialize has 127 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def initialize(user)
          user ||= User.new # guest user (not logged in)
          alias_action :create, :read, :update, :destroy, to: :crud
       
          # All users can do these things
      Severity: Major
      Found in app/models/ability.rb - About 5 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            }else{
              $(checkbox.data('reveals')).hide();
              $(checkbox.data('reveals')).find('input').each(function(){
                var input = $(this);
                switch(input.attr('type')) {
        Severity: Major
        Found in app/assets/javascripts/form_wizard.js and 1 other location - About 4 hrs to fix
        app/assets/javascripts/form_wizard.js on lines 28..42

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if(this.checked) {
              $(checkbox.data('hides')).hide();
              $(checkbox.data('hides')).find('input').each(function(){
                var input = $(this);
                switch(input.attr('type')) {
        Severity: Major
        Found in app/assets/javascripts/form_wizard.js and 1 other location - About 4 hrs to fix
        app/assets/javascripts/form_wizard.js on lines 53..68

        Method from_user has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
        Open

            def self.from_user(user, tags: [], interests: {})
              unless user.active?
                return self.from_params({
                  email_address: user.email,
                  name: user.name,
        Severity: Minor
        Found in app/models/mailchimp/contact.rb - About 4 hrs to fix

        File analysis.js has 334 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        "use strict";
         
        function updateDynamicTitles(titleWrapper, chartData) {
          var titleH3 = titleWrapper.find('h3');
          var titleH5 = titleWrapper.find('h5');
        Severity: Minor
        Found in app/assets/javascripts/analysis.js - About 4 hrs to fix

          Class BaseloadService has 32 methods (exceeds 20 allowed). Consider refactoring.
          Open

              class BaseloadService < BaseService
                include AnalysableMixin
           
                delegate :enough_data?, to: :baseload_service
           
           
          Severity: Minor
          Found in app/services/schools/advice/baseload_service.rb - About 4 hrs to fix

            Class Client has 32 methods (exceeds 20 allowed). Consider refactoring.
            Open

              class Client
                class ApiFailure < StandardError; end
                class BadRequest < StandardError; end
                class NotFound < StandardError; end
                class NotAllowed < StandardError; end
            Severity: Minor
            Found in lib/transifex/client.rb - About 4 hrs to fix

              Class HomeController has 31 methods (exceeds 20 allowed). Consider refactoring.
              Open

              class HomeController < ApplicationController
                include VideoHelper
                include ApplicationHelper
               
                # **** ALL ACTIONS IN THIS CONTROLLER ARE PUBLIC! ****
              Severity: Minor
              Found in app/controllers/home_controller.rb - About 3 hrs to fix

                Class AdviceBaseController has 31 methods (exceeds 20 allowed). Consider refactoring.
                Open

                    class AdviceBaseController < ApplicationController
                      include NonPublicSchools
                      include AdvicePageHelper
                      include SchoolAggregation
                      include DashboardAlerts
                Severity: Minor
                Found in app/controllers/schools/advice/advice_base_controller.rb - About 3 hrs to fix

                  Method invalid_row_check has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def invalid_row_check
                      @reading_data.each_with_index do |reading, index|
                        reading_date = reading[:reading_date]
                        readings = reading[:readings]
                   
                   
                  Severity: Minor
                  Found in app/models/amr_reading_data.rb - About 3 hrs to fix

                  Method initialize has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
                  Open

                    def initialize(user)
                      user ||= User.new # guest user (not logged in)
                      alias_action :create, :read, :update, :destroy, to: :crud
                   
                      # All users can do these things
                  Severity: Minor
                  Found in app/models/ability.rb - About 3 hrs to fix

                  Method charge_types has 88 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def self.charge_types
                      {
                        standing_charge: {
                          units: [:day, :month, :quarter],
                          name: I18n.t('user_tariff_charge.standing_charge')
                  Severity: Major
                  Found in app/models/energy_tariff_charge.rb - About 3 hrs to fix

                    Class MeterCostsTableComponent has 28 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    class MeterCostsTableComponent < ViewComponent::Base
                      # Monthly costs: a hash of Date (first day of month) => Costs::MeterMonth
                      # Change in costs: a hash of Date (first day of month) => change in total cost for month (£)
                      # id: HTML id of the table
                      # year_header: display year header row in table
                    Severity: Minor
                    Found in app/components/meter_costs_table_component.rb - About 3 hrs to fix

                      Function carbon has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
                      Open

                      export const carbon = ( function() {
                       
                        var local = {
                          neutral: '',
                          equivalences: '',
                      Severity: Minor
                      Found in app/javascript/transport_surveys/carbon.js - About 3 hrs to fix

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        module Cms
                          class SectionsController < AdminController
                            include LocaleHelper
                            load_and_authorize_resource :section, class: 'Cms::Section'
                       
                       
                      Severity: Major
                      Found in app/controllers/admin/cms/sections_controller.rb and 1 other location - About 3 hrs to fix
                      app/controllers/admin/cms/categories_controller.rb on lines 2..48

                      Similar blocks of code found in 2 locations. Consider refactoring.
                      Open

                        module Cms
                          class CategoriesController < AdminController
                            include LocaleHelper
                            load_and_authorize_resource :category, class: 'Cms::Category'
                       
                       
                      Severity: Major
                      Found in app/controllers/admin/cms/categories_controller.rb and 1 other location - About 3 hrs to fix
                      app/controllers/admin/cms/sections_controller.rb on lines 2..48
                      Severity
                      Category
                      Status
                      Source
                      Language