Sign upLogin

Battle-Cattle/BCUK-Bot-3

View on GitHub
Star
src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java

Summary

Maintainability
A
2 hrs
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public Task newTask()
    {
        List<Task> tasksToDo = tasks.findByCompleted(false);
        int size = tasksToDo.size();
        cTask = null;
Severity: Major
Found in src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java and 1 other location - About 1 hr to fix
src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java on lines 76..87

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public Punishment newPunishment()
    {
        List<Punishment> punishmentsAvailable = punishments.findByPunishmentGiven(false);
        int size = punishmentsAvailable.size();
        cPunishment = null;
Severity: Major
Found in src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java and 1 other location - About 1 hr to fix
src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java on lines 63..74

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 71.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Member name 'cTask' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    private Task cTask = null;
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java by checkstyle

Checks that instance variable names conform to a specified pattern.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

Member name 'cPunishment' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.
Open

    private Punishment cPunishment = null;
Severity: Minor
Found in src/main/java/com/expiredminotaur/bcukbot/fun/tasks/TaskManager.java by checkstyle

Checks that instance variable names conform to a specified pattern.

This documentation is written and maintained by the Checkstyle community and is covered under the same license as the Checkstyle project.

There are no issues that match your filters.

Category
Status