Sign upLogin

BeatSwitch/lock

View on GitHub
Star

Showing 8 of 8 total issues

PersistentDriverTestCase has 36 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class PersistentDriverTestCase extends \PHPUnit_Framework_TestCase
{
    /**
     * The main Lock instance
     *
Severity: Minor
Found in src/Tests/PersistentDriverTestCase.php - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function allowed($action, $resourceType)
        {
            $resourceType = $resourceType instanceof Resource ? $resourceType->getResourceType() : $resourceType;
     
            // Get all the ids from privileges which match the given resource type.
    Severity: Major
    Found in src/Lock.php and 1 other location - About 4 hrs to fix
    src/Lock.php on lines 159..173

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public function denied($action, $resourceType)
        {
            $resourceType = $resourceType instanceof Resource ? $resourceType->getResourceType() : $resourceType;
     
            // Get all the ids from restrictions which match the given resource type.
    Severity: Major
    Found in src/Lock.php and 1 other location - About 4 hrs to fix
    src/Lock.php on lines 136..150

    File PersistentDriverTestCase.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    namespace BeatSwitch\Lock\Tests;
     
    use BeatSwitch\Lock\Callers\SimpleCaller;
    use BeatSwitch\Lock\Manager;
    Severity: Minor
    Found in src/Tests/PersistentDriverTestCase.php - About 3 hrs to fix

      Lock has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class Lock
      {
          /**
           * @var \BeatSwitch\Lock\Manager
           */
      Severity: Minor
      Found in src/Lock.php - About 2 hrs to fix

        Function allow has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function allow($action, $resource = null, $resourceId = null, $conditions = [])
            {
                $actions = (array) $action;
                $resource = $this->convertResourceToObject($resource, $resourceId);
                $permissions = $this->getPermissions();
        Severity: Minor
        Found in src/Lock.php - About 55 mins to fix

        Function can has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function can($action, $resource = null, $resourceId = null)
            {
                $actions = (array) $action;
                $resource = $this->convertResourceToObject($resource, $resourceId);
                $permissions = $this->getPermissions();
        Severity: Minor
        Found in src/Lock.php - About 55 mins to fix

        Function clear has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function clear($action = null, $resource = null, $resourceId = null)
            {
                $actions = (array) $action;
                $resourceObject = $this->convertResourceToObject($resource, $resourceId);
                $permissions = $this->getPermissions();
        Severity: Minor
        Found in src/Lock.php - About 45 mins to fix
        Severity
        Category
        Status
        Source
        Language