Sign upLogin

BeatSwitch/lock

View on GitHub
Star

Showing 6 of 8 total issues

PersistentDriverTestCase has 36 functions (exceeds 20 allowed). Consider refactoring.
Open

abstract class PersistentDriverTestCase extends \PHPUnit_Framework_TestCase
{
    /**
     * The main Lock instance
     *
Severity: Minor
Found in src/Tests/PersistentDriverTestCase.php - About 4 hrs to fix

    File PersistentDriverTestCase.php has 300 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
namespace BeatSwitch\Lock\Tests;

use BeatSwitch\Lock\Callers\SimpleCaller;
use BeatSwitch\Lock\Manager;
    Severity: Minor
    Found in src/Tests/PersistentDriverTestCase.php - About 3 hrs to fix

      Lock has 21 functions (exceeds 20 allowed). Consider refactoring.
      Open

      abstract class Lock
{
    /**
     * @var \BeatSwitch\Lock\Manager
     */
      Severity: Minor
      Found in src/Lock.php - About 2 hrs to fix

        Function allow has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function allow($action, $resource = null, $resourceId = null, $conditions = [])
    {
        $actions = (array) $action;
        $resource = $this->convertResourceToObject($resource, $resourceId);
        $permissions = $this->getPermissions();
        Severity: Minor
        Found in src/Lock.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function can has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

            public function can($action, $resource = null, $resourceId = null)
    {
        $actions = (array) $action;
        $resource = $this->convertResourceToObject($resource, $resourceId);
        $permissions = $this->getPermissions();
        Severity: Minor
        Found in src/Lock.php - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function clear has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            public function clear($action = null, $resource = null, $resourceId = null)
    {
        $actions = (array) $action;
        $resourceObject = $this->convertResourceToObject($resource, $resourceId);
        $permissions = $this->getPermissions();
        Severity: Minor
        Found in src/Lock.php - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language